From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] rings: add the version major variable
Date: Tue, 28 Jan 2014 22:58:47 +0100 [thread overview]
Message-ID: <20140128225847.35ae8d12@skate> (raw)
In-Reply-To: <1389695458-19578-1-git-send-email-jerzy.grzegorek@trzebnica.net>
Dear Jerzy Grzegorek,
On Tue, 14 Jan 2014 11:30:57 +0100, Jerzy Grzegorek wrote:
> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
> ---
> package/rings/rings.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/rings/rings.mk b/package/rings/rings.mk
> index d052f5d..2876162 100644
> --- a/package/rings/rings.mk
> +++ b/package/rings/rings.mk
> @@ -4,7 +4,8 @@
> #
> ################################################################################
>
> -RINGS_VERSION = 1.3.0-1
> +RINGS_VERSION_MAJOR = 1.3.0
> +RINGS_VERSION = $(RINGS_VERSION_MAJOR)-1
> RINGS_SUBDIR = rings-v_1_3_0
> RINGS_LICENSE = MIT
While I agree with <foo>_VERSION_MAJOR, when <foo>_VERSION_MAJOR is
used in more than one place, I don't necessarily think it is needed
when it is used in only one place, <foo>_VERSION.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-28 21:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 10:30 [Buildroot] [PATCH 1/2] rings: add the version major variable Jerzy Grzegorek
2014-01-14 10:30 ` [Buildroot] [PATCH 2/2] package: unification of use $(subst [._-], [._-], $(<PKG>_VERSION)) macro Jerzy Grzegorek
2014-01-14 13:54 ` Peter Korsgaard
2014-01-14 10:54 ` [Buildroot] [PATCH 1/2] rings: add the version major variable Peter Korsgaard
2014-01-28 21:58 ` Thomas Petazzoni [this message]
2014-01-28 22:40 ` Jerzy Grzegorek
2014-01-29 6:35 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140128225847.35ae8d12@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox