From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libsocketcan: new package
Date: Wed, 29 Jan 2014 09:17:29 +0100 [thread overview]
Message-ID: <20140129091729.31b6ed77@skate> (raw)
In-Reply-To: <1389862821-16980-2-git-send-email-yegorslists@googlemail.com>
Hello Yegor,
On Thu, 16 Jan 2014 10:00:21 +0100, yegorslists at googlemail.com wrote:
> diff --git a/package/libsocketcan/libsocketcan.mk b/package/libsocketcan/libsocketcan.mk
> new file mode 100644
> index 0000000..920a900
> --- /dev/null
> +++ b/package/libsocketcan/libsocketcan.mk
> @@ -0,0 +1,10 @@
> +################################################################################
> +#
> +# libsocketcan
> +#
> +################################################################################
> +LIBSOCKETCAN_VERSION = 0.0.9
Missing empty newline between comment header and the first variable.
> +LIBSOCKETCAN_SITE = http://www.pengutronix.de/software/libsocketcan/download/
> +LIBSOCKETCAN_SOURCE = libsocketcan-$(LIBSOCKETCAN_VERSION).tar.bz2
> +
> +$(eval $(autotools-package))
Even if the license text is not available, it would have been good to
add LIBSOCKETCAN_LICENSE anyway.
Since Peter has already committed your patch, can you send a followup
patch to fix those two issues, against the latest master branch?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-01-29 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 9:00 [Buildroot] [PATCH] libsocketcan: license yegorslists at googlemail.com
2014-01-16 9:00 ` [Buildroot] [PATCH] libsocketcan: new package yegorslists at googlemail.com
2014-01-20 21:47 ` Peter Korsgaard
2014-01-29 8:17 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129091729.31b6ed77@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox