From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] Add gpm (general purpose mouse) server package
Date: Wed, 29 Jan 2014 16:03:34 +0100 [thread overview]
Message-ID: <20140129160334.0c50847b@skate> (raw)
In-Reply-To: <1391000525-5179-1-git-send-email-julien.boibessot@free.fr>
Julien,
On Wed, 29 Jan 2014 14:02:05 +0100, julien.boibessot at free.fr wrote:
> diff --git a/package/gpm/Config.in b/package/gpm/Config.in
> new file mode 100644
> index 0000000..d20e392
> --- /dev/null
> +++ b/package/gpm/Config.in
> @@ -0,0 +1,24 @@
> +config BR2_PACKAGE_GPM
> + bool "gpm mouse server"
I believe we normally don't describe what the component is in its short
description. It should just be the name, i.e "gpm", unless the name of
the project is really "gpm mouse server".
> +config BR2_PACKAGE_GPM_INSTALL_TEST_TOOLS
> + bool "install gpm test tools also"
Why do we have "also" here ? This should probably just be:
bool "install test tools"
there is no need to repeat "gpm", because this option is automatically
shown "under" the gpm option.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-01-29 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 13:02 [Buildroot] [PATCH v3] Add gpm (general purpose mouse) server package julien.boibessot at free.fr
2014-01-29 15:03 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129160334.0c50847b@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox