Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 6/6] Makefile: export PATH
Date: Fri, 31 Jan 2014 09:33:47 +0100	[thread overview]
Message-ID: <20140131093347.5c3bcbae@skate> (raw)
In-Reply-To: <1391114333-28001-7-git-send-email-s.martin49@gmail.com>

Dear Samuel Martin,

On Thu, 30 Jan 2014 21:38:53 +0100, Samuel Martin wrote:
> This can be useful for:
> - package using custom build system that are not aware that the host
>   tree is in $(O)/host/;
> - post-{build,image} scripts, in case some host-tools were specifically
>   built to be used by these scripts.
> 
> Note that, this patch only exports the PATH variables; cleaning up
> all the explicit PATH declarations leading some commands could be done
> in a followup patch.

So with this patch, passing PATH in all the package infrastructures
(cmake, autotools, python) becomes unnecessary?

I must say I am not entirely sure we want to globally export PATH.
Packages using custom build system should use TARGET_MAKE_ENV and
HOST_MAKE_ENV, post-build and post-image script have HOST_DIR defined
in their environment I believe.

But this is not a strong opinion, I'd just like to see
arguments/opinions from others on this specific change (the other
changes in the series, I'm happy with them on the principle, they are
just a few remaining details to sort out).

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-01-31  8:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 20:38 [Buildroot] [PATCH v3 0/6] PATH cleanup Samuel Martin
2014-01-30 20:38 ` [Buildroot] [PATCH v3 1/6] Makefile: introduce BR2_PATH Samuel Martin
2014-01-31  8:25   ` Thomas Petazzoni
2014-01-31  8:41     ` Jeremy Rosen
2014-01-31  9:08       ` Thomas Petazzoni
2014-01-31 10:13     ` Samuel Martin
2014-01-30 20:38 ` [Buildroot] [PATCH v3 2/6] Makefile: add $(HOST_DIR)/sbin to BR2_PATH Samuel Martin
2014-01-31  8:25   ` Thomas Petazzoni
2014-01-30 20:38 ` [Buildroot] [PATCH v3 3/6] *.mk: replace (TARGET|HOST)_PATH by BR2_PATH Samuel Martin
2014-01-31  8:31   ` Thomas Petazzoni
2014-01-30 20:38 ` [Buildroot] [PATCH v3 4/6] infra: remove unused {TARGET, HOST}_PATH definition Samuel Martin
2014-01-30 20:38 ` [Buildroot] [PATCH v3 5/6] pkg-cmake.mk: add PATH in the configure command environment Samuel Martin
2014-01-30 20:38 ` [Buildroot] [PATCH v3 6/6] Makefile: export PATH Samuel Martin
2014-01-31  8:33   ` Thomas Petazzoni [this message]
2014-02-04  9:05     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140131093347.5c3bcbae@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox