Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4 of 7] packages: remove support for documentation on target
Date: Wed, 5 Feb 2014 14:34:11 +0100	[thread overview]
Message-ID: <20140205143411.0b6a023d@skate> (raw)
In-Reply-To: <CAAXf6LVJTnL67SZ0pSAahtndP_dPCkOHRjFd7bSydwkh__EqJQ@mail.gmail.com>

Dear Thomas De Schampheleire,

On Wed, 5 Feb 2014 14:28:48 +0100, Thomas De Schampheleire wrote:

> Looking at this file, I don't know if your suggestion makes sense.
> Here is part of the original file:
> 
> -----------------------------------
> KMOD_VERSION = 16
> KMOD_SOURCE = kmod-$(KMOD_VERSION).tar.xz
> KMOD_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/kernel/kmod/
> KMOD_INSTALL_STAGING = YES
> KMOD_DEPENDENCIES = host-pkgconf
> HOST_KMOD_DEPENDENCIES = host-pkgconf
> 
> # license info for libkmod only, conditionally add more below
> KMOD_LICENSE = LGPLv2.1+
> KMOD_LICENSE_FILES = libkmod/COPYING
> 
> # static linking not supported, see
> # https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/?id=b7016153ec8
> KMOD_CONF_OPT = --disable-static --enable-shared
> 
> # manpages not installed and needs xsltproc
> HOST_KMOD_CONF_OPT = --disable-manpages
> KMOD_CONF_OPT += --disable-manpages
> 
> ifeq ($(BR2_PACKAGE_ZLIB),y)
> KMOD_DEPENDENCIES += zlib
> KMOD_CONF_OPT += --with-zlib
> endif
> 
> ifeq ($(BR2_PACKAGE_XZ),y)
> KMOD_DEPENDENCIES += xz
> KMOD_CONF_OPT += --with-xz
> endif
> ------------------------------------
> 
> I can certainly put the two manpage-related lines above the static
> linking, but this is just a move in the file, right?

You're right, I agree my suggestion doesn't make much sense. Just keep
your patch as it was, it is good.

Sorry for the noise :/

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-02-05 13:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 10:50 [Buildroot] [PATCH 0 of 7] Remove remaining deprecated packages for 2014.02 Thomas De Schampheleire
2014-02-05 10:50 ` [Buildroot] [PATCH 1 of 7] xstroke: remove deprecated package Thomas De Schampheleire
2014-02-05 10:50 ` [Buildroot] [PATCH 2 of 7] autoconf: remove deprecated target package Thomas De Schampheleire
2014-02-05 10:50 ` [Buildroot] [PATCH 3 of 7] automake: " Thomas De Schampheleire
2014-02-05 10:50 ` [Buildroot] [PATCH 4 of 7] packages: remove support for documentation on target Thomas De Schampheleire
2014-02-05 12:49   ` Thomas Petazzoni
2014-02-05 13:10     ` Thomas De Schampheleire
2014-02-05 13:16       ` Thomas Petazzoni
2014-02-05 13:28         ` Thomas De Schampheleire
2014-02-05 13:34           ` Thomas Petazzoni [this message]
2014-02-05 21:21         ` Arnout Vandecappelle
2014-02-06  8:37           ` Thomas Petazzoni
2014-02-06 10:26             ` Arnout Vandecappelle
2014-02-06 11:34               ` Thomas De Schampheleire
2014-02-06 11:40                 ` Thomas Petazzoni
2014-02-06 12:15                   ` Thomas De Schampheleire
2014-02-06 13:33                   ` Arnout Vandecappelle
2014-02-06 22:19                   ` Peter Korsgaard
2014-02-05 10:50 ` [Buildroot] [PATCH 5 of 7] ccache: remove deprecated target package Thomas De Schampheleire
2014-02-05 10:50 ` [Buildroot] [PATCH 6 of 7] gdb: remove deprecated versions 7.2.x and 7.3.x Thomas De Schampheleire
2014-02-05 10:50 ` [Buildroot] [PATCH 7 of 7] kernel-headers: remove deprecated versions 3.1, 3.3, 3.5 Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140205143411.0b6a023d@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox