From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] filter BR2_DEFCONFIG out of defconfig files
Date: Wed, 5 Feb 2014 19:22:46 +0100 [thread overview]
Message-ID: <20140205182246.GA19446@free.fr> (raw)
In-Reply-To: <1391523148-30887-1-git-send-email-jeremy.rosen@openwide.fr>
J?r?my, All,
On 2014-02-04 15:12 +0100, J?r?my Rosen spake thusly:
> When it is set, BR2_DEFCONFIG is saved like any config variable.
> However, at this point it is a completely expanded, absolute path
> It is not a good idea to save absolute paths in defconfig files
> moreover it makes little sense to save the defconfig location
> within the defconfig
>
> Signed-off-by: J?r?my Rosen <jeremy.rosen@openwide.fr>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 4a675d4..f63a058 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -772,6 +772,7 @@ savedefconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
> @$(COMMON_CONFIG_ENV) $< \
> --savedefconfig=$(if $(DEFCONFIG),$(DEFCONFIG),$(CONFIG_DIR)/defconfig) \
> $(CONFIG_CONFIG_IN)
> + sed -i '/^BR2_DEFCONFIG=/d' $(DEFCONFIG)
Should be:
$(SED) '/blabla/'
$(SED) already contains -i
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-02-05 18:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 14:12 [Buildroot] [PATCH] filter BR2_DEFCONFIG out of defconfig files Jérémy Rosen
2014-02-05 11:54 ` Thomas De Schampheleire
2014-02-05 22:46 ` Arnout Vandecappelle
2014-02-05 23:18 ` Yann E. MORIN
2014-02-06 7:50 ` Thomas De Schampheleire
2014-02-06 21:15 ` Arnout Vandecappelle
2014-02-05 18:22 ` Yann E. MORIN [this message]
2014-02-05 22:43 ` Arnout Vandecappelle
2014-02-06 8:25 ` Jeremy Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205182246.GA19446@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox