Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] dmraid: disable on ARC arch
Date: Fri, 7 Feb 2014 09:00:58 +0100	[thread overview]
Message-ID: <20140207090058.75ced0b6@skate> (raw)
In-Reply-To: <1391727417-12293-1-git-send-email-rjbarnet@rockwellcollins.com>

Dear Ryan Barnett,

On Thu,  6 Feb 2014 23:56:56 +0100, Ryan Barnett wrote:

> diff --git a/package/dmraid/Config.in b/package/dmraid/Config.in
> index 028b46c..2f0c5b4 100644
> --- a/package/dmraid/Config.in
> +++ b/package/dmraid/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_DMRAID
>  	bool "dmraid"
>  	depends on BR2_LARGEFILE
>  	depends on BR2_USE_MMU # lvm2
> +	depends on !BR2_arc

I believe it would be good to have a comment above this line that says
why it's disabled. Maybe something like:

	# causes an internal compiler error on ARC

Ditto for the gpsd issue on Microblaze.

And maybe Cc the ARC and Microblaze "maintainers" : Anton Kolesov
<Anton.Kolesov@synopsys.com> for ARC, and Spenser Gilliland
<spenser@gillilanding.com> for Microblaze.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-02-07  8:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06 22:56 [Buildroot] [PATCH 1/2] dmraid: disable on ARC arch Ryan Barnett
2014-02-06 22:56 ` [Buildroot] [PATCH 2/2] gpsd: disable for microblaze arch Ryan Barnett
2014-02-08 21:54   ` Peter Korsgaard
2014-02-07  8:00 ` Thomas Petazzoni [this message]
2014-02-08 21:52 ` [Buildroot] [PATCH 1/2] dmraid: disable on ARC arch Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140207090058.75ced0b6@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox