Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 2/4] udev: convert to virtual package.
Date: Mon, 10 Feb 2014 12:22:49 +0100	[thread overview]
Message-ID: <20140210112249.GB22843@pc-eric> (raw)
In-Reply-To: <CAHXCMMJ6aOmS+BN9vXNNeC1UBym6SbzZoHdX4eFa37CmsWWo1w@mail.gmail.com>

Hi!

On Fri, Feb 07, 2014 at 10:30:15PM +0100, Samuel Martin wrote:
> > diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> > index e157ca8..fe60850 100644
> > --- a/package/modem-manager/Config.in
> > +++ b/package/modem-manager/Config.in
> > @@ -1,6 +1,6 @@
> >  config BR2_PACKAGE_MODEM_MANAGER
> >         bool "modemmanager"
> > -       depends on BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
> > +       depends on BR2_PACKAGE_HAS_UDEV
> >         select BR2_PACKAGE_DBUS
> >         depends on BR2_INET_IPV6
> >         depends on BR2_LARGEFILE # acl
> > @@ -8,8 +8,6 @@ config BR2_PACKAGE_MODEM_MANAGER
> >         depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
> >         depends on BR2_USE_MMU # dbus
> >         select BR2_PACKAGE_DBUS_GLIB
> > -       select BR2_PACKAGE_UDEV
> > -       select BR2_PACKAGE_UDEV_ALL_EXTRAS
>
> When removing BR2_PACKAGE_UDEV_ALL_EXTRAS, you should certainly
> replace it by the
> "select ..." statements done in the BR2_PACKAGE_UDEV_ALL_EXTRAS
> symbol, ie: acl and libglib2 (if I understood correctly hwdata is no
> longer needed).
In fact BR2_PACKAGE_DBUS_GLIB already selects BR2_PACKAGE_LIBGLIB2, so only
BR2_PACKAGE_ACL is needed. I will fix this.

Thanks for your review.

Best regards,
ELB

  reply	other threads:[~2014-02-10 11:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 13:21 [Buildroot] [PATCH v7 0/4] udev is now provided by systemd or eudev Eric Le Bihan
2014-02-07 13:21 ` [Buildroot] [PATCH v7 1/4] eudev: new package Eric Le Bihan
2014-02-07 19:14   ` Thomas De Schampheleire
2014-02-10 11:16     ` Eric Le Bihan
2014-02-07 13:21 ` [Buildroot] [PATCH v7 2/4] udev: convert to virtual package Eric Le Bihan
2014-02-07 20:17   ` Thomas De Schampheleire
2014-02-07 21:14     ` Eric Le Bihan
2014-02-07 22:56       ` Yann E. MORIN
2014-02-07 21:30   ` Samuel Martin
2014-02-10 11:22     ` Eric Le Bihan [this message]
2014-02-07 13:21 ` [Buildroot] [PATCH v7 3/4] systemd: bump to v207 Eric Le Bihan
2014-02-07 20:24   ` Thomas De Schampheleire
2014-02-07 22:00   ` Samuel Martin
2014-02-10 13:26     ` Eric Le Bihan
2014-02-10 13:44       ` Samuel Martin
2014-02-07 13:21 ` [Buildroot] [PATCH v7 4/4] manual: update /dev management section Eric Le Bihan
2014-02-07 20:26   ` Thomas De Schampheleire
2014-02-07 22:04     ` Samuel Martin
2014-02-07 20:34 ` [Buildroot] [PATCH v7 0/4] udev is now provided by systemd or eudev Arnout Vandecappelle
2014-02-07 20:39   ` Thomas De Schampheleire
2014-02-10 13:44   ` Eric Le Bihan
2014-02-10 18:25     ` Thomas Petazzoni
2014-02-12 21:34 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140210112249.GB22843@pc-eric \
    --to=eric.le.bihan.dev@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox