From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libtorrent: disable on ARC arch
Date: Mon, 10 Feb 2014 13:17:34 +0100 [thread overview]
Message-ID: <20140210131734.15cad107@skate> (raw)
In-Reply-To: <CAAXf6LWF4yj4E26ynNoP2EMhCkD3fin7Z9Coqoj9M26ZD3LxaQ@mail.gmail.com>
Thomas, Anton,
On Mon, 10 Feb 2014 12:33:06 +0100, Thomas De Schampheleire wrote:
> > + # ARC GCC doesn't support atomic instructions required by this lib
> > + depends on !BR2_arc
Wrong indentation: one tab should be used.
> > select BR2_PACKAGE_LIBSIGC
> > help
> > BitTorrent library written in C++ for *nix
>
> This extra 'depends on' should be repeated on the comment about
> toolchain options below, so that this comment is only visible when the
> actual package is visible.
> Have a look at http://buildroot.uclibc.org/downloads/manual/manual.html#dependencies-target-toolchain-options
>
> (Note: you don't have to repeat the "# ARG GCC doesn't support ..." on
> the comment)
And this additional dependency should be propagated to the reverse
dependencies of libtorrent, i.e the rtorrent package.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-10 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 11:27 [Buildroot] [PATCH] libtorrent: disable on ARC arch Anton Kolesov
2014-02-10 11:33 ` Thomas De Schampheleire
2014-02-10 12:17 ` Thomas Petazzoni [this message]
2014-02-10 12:39 ` [Buildroot] [PATCH v2] " Anton Kolesov
2014-02-10 12:53 ` Thomas Petazzoni
2014-02-10 14:09 ` [Buildroot] [PATCH v3] " Anton Kolesov
2014-02-10 14:24 ` Thomas Petazzoni
2014-02-10 14:42 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210131734.15cad107@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox