From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 18 Feb 2014 23:17:21 +0100 Subject: [Buildroot] [PATCH v2 06/20] python3: add config directory symbolic link In-Reply-To: <87ob243x08.fsf@dell.be.48ers.dk> References: <1392756013-27757-1-git-send-email-thomas.petazzoni@free-electrons.com> <1392756013-27757-7-git-send-email-thomas.petazzoni@free-electrons.com> <87ob243x08.fsf@dell.be.48ers.dk> Message-ID: <20140218231721.5f3f195b@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Peter Korsgaard, On Tue, 18 Feb 2014 22:56:55 +0100, Peter Korsgaard wrote: > > -HOST_PYTHON3_POST_INSTALL_HOOKS += HOST_PYTHON3_INSTALL_SYMLINK > > +# Alias the python/config-m to python/config > > +# This is needed when installing an external python module, because > > +# the setup is looking for files in python/config/ > > +define HOST_PYTHON3_INSTALL_CONFIG_SYMLINK > > + ln -fs config-$(PYTHON3_VERSION_MAJOR)m $(HOST_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOE)config > > Ehh, shouldn't this be ..$(HOST_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/config? > > As you didn't notice, perhaps the symlink isn't really needed after all? I tested without this patch, and indeed, I could build Python 3 and all the external modules that can be enabled with Python 3 without problem. So I believe it may no longer be necessary with the Python 3 bump to 3.4. I have tested, and patches 7 onwards apply without problem if you discard PATCH 6. So I guess there is no need for me to resend the series, you can just continue to apply it starting from PATCH 7, if you don't mind. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com