From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 19 Feb 2014 11:09:55 +0100 Subject: [Buildroot] [PATCH 1/3] mplayer: not available on bfin In-Reply-To: <1392803602-5566-2-git-send-email-fabio.porcedda@gmail.com> References: <1392803602-5566-1-git-send-email-fabio.porcedda@gmail.com> <1392803602-5566-2-git-send-email-fabio.porcedda@gmail.com> Message-ID: <20140219110955.41b0c690@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Fabio Porcedda, On Wed, 19 Feb 2014 10:53:20 +0100, Fabio Porcedda wrote: > Fixes: > http://autobuild.buildroot.net/results/109/109b7c9b575c7362c4982a908a1e3695e7590ebd/ > > Signed-off-by: Fabio Porcedda > --- > package/libplayer/Config.in | 3 ++- > package/mplayer/Config.in | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/package/libplayer/Config.in b/package/libplayer/Config.in > index 113f650..84dad1d 100644 > --- a/package/libplayer/Config.in > +++ b/package/libplayer/Config.in > @@ -13,7 +13,8 @@ if BR2_PACKAGE_LIBPLAYER > config BR2_PACKAGE_LIBPLAYER_MPLAYER > bool "mplayer backend" > # mplayer > - depends on !BR2_sh4a && !BR2_sh4aeb && !BR2_microblaze && !BR2_aarch64 > + depends on !(BR2_bfin || BR2_sh4a || BR2_sh4aeb || BR2_microblaze || \ > + BR2_aarch64) > # mplayer > depends on BR2_LARGEFILE > # mplayer > diff --git a/package/mplayer/Config.in b/package/mplayer/Config.in > index ae273e4..f2b3620 100644 > --- a/package/mplayer/Config.in > +++ b/package/mplayer/Config.in > @@ -1,7 +1,7 @@ > config BR2_PACKAGE_MPLAYER > bool "mplayer" > # Those architectures are not supported by MPlayer > - depends on !(BR2_sh2a || BR2_sh4a || BR2_sh4aeb \ > + depends on !(BR2_bfin || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \ > || BR2_microblaze || BR2_aarch64 || BR2_nios2) I believe it's time to switch to a different logic. What about: config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS bool depends on and then use "depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS" / "depends on !BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS" all over the place instead of duplicating the list of architectures everywhere. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com