From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] webkit: disable on < ARMv5t
Date: Thu, 20 Feb 2014 09:05:55 +0100 [thread overview]
Message-ID: <20140220090555.42dc8d0d@skate> (raw)
In-Reply-To: <53059EBE.6030902@mind.be>
Dear Arnout Vandecappelle,
On Thu, 20 Feb 2014 07:20:46 +0100, Arnout Vandecappelle wrote:
> > diff --git a/package/webkit/Config.in b/package/webkit/Config.in
> > index 0207a6d..daaec36 100644
> > --- a/package/webkit/Config.in
> > +++ b/package/webkit/Config.in
> > @@ -1,11 +1,18 @@
> > +config BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
> > + bool
> > + # ARM needs BLX, so v5t+
> > + default y if (BR2_arm || BR2_armeb) && \
> > + !(BR2_arm7tdmi || BR2_arm720t || BR2_arm920t || BR2_arm922t || BR2_fa526)
> > + default y if BR2_i386 || BR2_mips || BR2_mipsel || \
> > + BR2_powerpc || BR2_sh || BR2_sparc || BR2_x86_64
>
> We normally write
>
> depends on FOO
> depends on BAR
>
> rather than
>
> depends on FOO && BAR
>
> Shouldn't we do the same here?
>
> default y if BR2_i386
> default y if BR2_mips
Are you talking about the first line (about ARM), or the second line
(for all the other architectures) ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-20 8:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 22:08 [Buildroot] [PATCH] webkit: disable on < ARMv5t Thomas Petazzoni
2014-02-20 6:20 ` Arnout Vandecappelle
2014-02-20 8:05 ` Thomas Petazzoni [this message]
2014-02-20 9:55 ` Arnout Vandecappelle
2014-02-20 10:18 ` Thomas Petazzoni
2014-02-20 7:57 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220090555.42dc8d0d@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox