[Buildroot] [PATCH] toolchain: control GNU_TARGET_NAME vendor part

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Noam Camus,

(Please do not top post. It would also be nice if you used a mail
client that wrapped lines at a reasonable length.)

On Sun, 23 Feb 2014 11:45:46 +0000, Noam Camus wrote:

> Here (EZchip) we change toolchain elements such binutils/gdb kernel (headers) and gcc.
> We are using override feature of buildroot to create our custom buildroot toolchain.
> One of the GCC changes we carry is that we assume dedicated vendor (ezchip) to control several GCC defaults and enable extra configurations within GCC.

Hum, ok. Is the vendor part of the tuple meant to be used this way?

> About "unknown" I guess that it can be blocked by checking the value and in some cases cause intentional make error.
> 
> I hope this makes sense to you.

Right. I guess we can make this configurable. However, your patch has
some issues:

 * It only creates the option BR2_TOOLCHAIN_BUILDROOT_VENDOR in the
   internal toolchain backend. But GNU_TARGET_NAME is also used with
   the external toolchain backend, which means in the external
   toolchain case we would end up with a GNU_TARGET_NAME having an
   empty vendor part of the tuple.

 * The new Config.in option lacks an help text, and the help text
   should explain in detail how this should be used, and in which
   situations. Also the title of the help text should be just
   "custom toolchain vendor name".

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com