Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] manual: Add a note for dependency comment format
Date: Sun, 23 Feb 2014 15:44:21 +0100	[thread overview]
Message-ID: <20140223154421.0bb178b1@skate> (raw)
In-Reply-To: <CAGduivyrc0Gk92pbS=-0TLSp4xWDnV54hz1mzH-ixvHCD1hOrw@mail.gmail.com>

Dear Maxime Hadjinlian,

On Sun, 23 Feb 2014 15:35:37 +0100, Maxime Hadjinlian wrote:
> Hi Thomas, all
> On Sun, Feb 23, 2014 at 3:04 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
> > Dear Maxime Hadjinlian,
> >
> > On Sun, 23 Feb 2014 14:05:48 +0100, Maxime Hadjinlian wrote:
> >> Add a quick note to clarify that the format of the depencency comments
> >> applies irregardless of the number of dependencies.
> >>
> >> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> >> ---
> >>  docs/manual/adding-packages-directory.txt | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
> >> index 3dc5395..b6dc981 100644
> >> --- a/docs/manual/adding-packages-directory.txt
> >> +++ b/docs/manual/adding-packages-directory.txt
> >> @@ -205,6 +205,7 @@ aircrack-ng needs a toolchain w/ largefile, threads
> >>
> >>  Note that this text is kept brief on purpose, so that it will fit on a
> >>  80-character terminal.
> >> +This format must be repected even if there is only one dependency.
> >
> > I'm not sure what you mean here. Could you explain a bit more?
> The examples always give with n depedency. Someone may ask himself if
> this format is valid for only one depedency.
> Should it reduce the with to w/, etc...

Then it is unclear, because your sentence come right after the sentence
mentioning the 80-character limit. So when I read this, I thought you
were saying "even when there is a single dependency, the text must fit
on a 80-character terminal", which doesn't made much sense.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-02-23 14:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-23 13:05 [Buildroot] [PATCH] manual: Add a note for dependency comment format Maxime Hadjinlian
2014-02-23 14:04 ` Thomas Petazzoni
2014-02-23 14:35   ` Maxime Hadjinlian
2014-02-23 14:44     ` Thomas Petazzoni [this message]
2014-02-23 14:47       ` Maxime Hadjinlian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140223154421.0bb178b1@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox