From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 27 Feb 2014 23:59:52 +0100 Subject: [Buildroot] [PATCH 1/4] luajit: refactor without dont-strip.patch In-Reply-To: <1390465713-12600-1-git-send-email-francois.perrad@gadz.org> References: <1390465713-12600-1-git-send-email-francois.perrad@gadz.org> Message-ID: <20140227235952.4bde8034@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Francois Perrad, On Thu, 23 Jan 2014 09:28:30 +0100, Francois Perrad wrote: > the variable TARGET_STRIP does the job > > Signed-off-by: Francois Perrad > --- > package/luajit/luajit-03-dont-strip.patch | 23 ----------------------- > package/luajit/luajit.mk | 2 +- > 2 files changed, 1 insertion(+), 24 deletions(-) > delete mode 100644 package/luajit/luajit-03-dont-strip.patch Looks good to me. Just a question below. > + TARGET_STRIP=@: \ Any reason to use @: instead of just : ? Also, personally, I would probably prefer TARGET_STRIP=true. I know it's the same, but I find the usage of ':' a bit hard to read. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com