From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lzip: new package
Date: Sat, 1 Mar 2014 14:46:09 +0100 [thread overview]
Message-ID: <20140301144609.016009bd@skate> (raw)
In-Reply-To: <1393599281-28078-1-git-send-email-gustavo@zacarias.com.ar>
Dear Gustavo Zacarias,
On Fri, 28 Feb 2014 11:54:41 -0300, Gustavo Zacarias wrote:
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Since you're adding a host variant of the package, it would be good to
have some details in the commit log as to why this is necessary.
> +define LZIP_CONFIGURE_CMDS
> + (cd $(@D); ./configure \
> + CXX="$(TARGET_CXX)" \
> + CPPFLAGS="$(TARGET_CPPFLAGS)" \
> + CXXFLAGS="$(TARGET_CXXFLAGS)" \
> + LDFLAGS="$(TARGET_LDFLAGS)" \
> + --prefix=/usr )
> +
> +endef
Useless blank line before endef.
If you're using the generic-package infra, I suppose it's because the
configure script isn't autotools-based. It would be good to mention
that in a comment before LZIP_CONFIGURE_CMDS.
Also, what about using TARGET_CONFIGURE_OPTS / HOST_CONFIGURE_OPTS
instead of passing CXX, CPPFLAGS, CXXFLAGS and LDFLAGS ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-03-01 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 14:54 [Buildroot] [PATCH] lzip: new package Gustavo Zacarias
2014-03-01 13:46 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140301144609.016009bd@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox