Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] lvm2: add readline bump fix patch
Date: Sat, 1 Mar 2014 20:57:35 +0100	[thread overview]
Message-ID: <20140301205735.1ce79e0f@skate> (raw)
In-Reply-To: <5312392A.10708@zacarias.com.ar>

Dear Gustavo Zacarias,

On Sat, 01 Mar 2014 16:46:50 -0300, Gustavo Zacarias wrote:
> On 03/01/2014 04:42 PM, Thomas Petazzoni wrote:
> 
> > Dear Gustavo Zacarias,
> > 
> > On Sat,  1 Mar 2014 16:21:03 -0300, Gustavo Zacarias wrote:
> > 
> >> +The CPPFunction typedef (among others) have been deprecated in favour of
> > 
> > s/have/has/
> > 
> >> +specific prototyped typedefs since readline 4.2.
> >> +They've been working since because compatibility typedefs have been
> >> +until they were removed in readline 6.3.
> > 
> > I don't understand this last sentence. Is it my english that it too
> > limited, or because the sentence doesn't make sense? :-)
> > 
> > Same question for PATCH 2/2, which has the same issue.
> 
> Pff i'm still on vacation ;)
> AFAIK 'have' is valid since i'm talking of many though i'm focusing on
> just one in the patch.
> "They've been working" (the typedefs) "since" (the deprecation) "because
> compatibility typedefs have been" (+ in place... missing that) until
> they were removed in readline 6.3

May I request new patches that fix these minor issues?

Thanks :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-03-01 19:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-01 19:21 [Buildroot] [PATCH 1/2] lvm2: add readline bump fix patch Gustavo Zacarias
2014-03-01 19:21 ` [Buildroot] [PATCH 2/2] parted: " Gustavo Zacarias
2014-03-01 19:42 ` [Buildroot] [PATCH 1/2] lvm2: " Thomas Petazzoni
2014-03-01 19:46   ` Gustavo Zacarias
2014-03-01 19:57     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140301205735.1ce79e0f@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox