Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 11/13] pkg-infra: add possiblity to check downloaded files against known hashes
Date: Sun, 2 Mar 2014 23:19:59 +0100	[thread overview]
Message-ID: <20140302221959.GB3379@free.fr> (raw)
In-Reply-To: <CAHXCMMLfCntMjYv4ONecSyhLGph=+CdR5mJu92bkCbfxYWhTzA@mail.gmail.com>

Samuel, All,

On 2014-03-02 21:10 +0100, Samuel Martin spake thusly:
> Yann,
> 
> On Sun, Mar 2, 2014 at 6:51 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > Some of the packages that Buildroot might build are sensitive packages,
> > related to security: openssl, dropbear, ca-certificates...
> >
> > Some of those packages are downloaded over plain http, because there is
> > no way to get them over a secure channel, such as https.
> >
> > In these dark times of pervasive surveillance, the potential for harm that
> > a tampered-with package could generate, we may want to check the integrity
> > of those sensitive packages.
> >
> > So, each package may now provide a list of hashes for all files that needs
> > to be downloaded, and Buildroot will just fail if any downloaded file does
> > not match its known hash.
> >
> > Hashes can be any of the sha1 or sha2 variants, and will be checked even if
> > the file was pre-downloaded.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Baruch Siach <baruch@tkos.co.il>
> > Cc: Arnout Vandecappelle <arnout@mind.be>
> > ---
> > Note: this is not a bullet-proof solution, since Buildroot may itself be
> > compromised. But since we do sign our releases, then we secure the list of
> > hashes at the same time. Only random snapshots from the repository may be
> > at risk of tampering, although this is highly doubtfull, given how git
> > stores its data.
> > ---
> >  package/pkg-download.mk     | 27 +++++++++++------
> >  support/download/check-hash | 71 +++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 89 insertions(+), 9 deletions(-)
> >  create mode 100755 support/download/check-hash
> >
> > diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> > index c94ecba..adaccef 100644
> > --- a/package/pkg-download.mk
> > +++ b/package/pkg-download.mk
> > @@ -58,6 +58,17 @@ domainseparator=$(if $(1),$(1),/)
> >  # github(user,package,version): returns site of github repository
> >  github = https://github.com/$(1)/$(2)/tarball/$(3)
> >
> > +# Helper for checking a tarball's checksum
> > +# If the hash does not match, remove the incorrect file
> > +# $(1): the path to the fies with the hashes
> 
> nit:
> s/fies/file/

Already spotted by Gustavo on IRC. Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-03-02 22:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-02 17:51 [Buildroot] [PATCH 0/13 v2] some download-related changes Yann E. MORIN
2014-03-02 17:51 ` [Buildroot] [PATCH 01/13] pkg-infra: DOWNLOAD is never called with two arguments Yann E. MORIN
2014-03-02 20:01   ` Thomas Petazzoni
2014-03-02 17:51 ` [Buildroot] [PATCH 02/13] Makefile: rename USER_HOOKS_EXTRA_ENV to EXTRA_ENV Yann E. MORIN
2014-03-02 17:51 ` [Buildroot] [PATCH 03/13] Makefile: add BR2_DL_DIR " Yann E. MORIN
2014-03-05  6:29   ` Arnout Vandecappelle
2014-03-02 17:51 ` [Buildroot] [PATCH 04/13] pkg-infra: move the git download helper to a script Yann E. MORIN
2014-03-05  6:34   ` Arnout Vandecappelle
2014-03-02 17:51 ` [Buildroot] [PATCH 05/13] pkg-infra: move the svn " Yann E. MORIN
2014-03-02 17:51 ` [Buildroot] [PATCH 06/13] pkg-infra: move the cvs " Yann E. MORIN
2014-03-02 17:51 ` [Buildroot] [PATCH 07/13] pkg-infra: move the hg " Yann E. MORIN
2014-03-02 17:51 ` [Buildroot] [PATCH 08/13] pkg-infra: move the wget " Yann E. MORIN
2014-03-02 17:51 ` [Buildroot] [PATCH 09/13] pkg-infra: don't use DL_DIR as scratchpad for temporary VCS checkouts Yann E. MORIN
2014-03-02 17:51 ` [Buildroot] [PATCH 10/13] pkg-infra: also set PKGDIR for the download step Yann E. MORIN
2014-03-02 17:51 ` [Buildroot] [PATCH 11/13] pkg-infra: add possiblity to check downloaded files against known hashes Yann E. MORIN
2014-03-02 20:10   ` Samuel Martin
2014-03-02 22:19     ` Yann E. MORIN [this message]
2014-03-02 17:51 ` [Buildroot] [PATCH 12/13] manual: add documentation about packages' hashes Yann E. MORIN
2014-03-02 17:51 ` [Buildroot] [PATCH 13/13] package/ca-certificates: add tarball's hashes Yann E. MORIN
2014-03-02 20:14 ` [Buildroot] [PATCH 0/13 v2] some download-related changes Samuel Martin
2014-03-02 20:55   ` Thomas De Schampheleire
2014-03-02 22:32     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140302221959.GB3379@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox