From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 2/4] Makefile: export PATH including the Buildroot host bindirs
Date: Tue, 4 Mar 2014 22:52:34 +0100 [thread overview]
Message-ID: <20140304225234.164382f9@skate> (raw)
In-Reply-To: <53160821.9080907@mind.be>
Dear Arnout Vandecappelle,
On Tue, 04 Mar 2014 18:06:41 +0100, Arnout Vandecappelle wrote:
> On 01/03/14 20:59, Samuel Martin wrote:
> > This patch exports the PATH variable containing the factorized content
> > of TARGET_PATH and HOST_PATH (because they were fairly similar).
> >
> > TARGET_PATH and HOST_PATH are now set using only the PATH variable.
> >
> > Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>
> Looks good to me.
>
> Except... I'm having second thoughts about the principle of this patch.
> When debugging failing builds, I often copy&paste the build command line
> if I want to drill down to the details of the error. But if PATH is
> exported (and TARGET_PATH is removed, in 4/4), it is no longer visible on
> the command line... So I have to remember to set it myself...
True. I also do that very often.
I personally dislike exporting the PATH globally, as it means that
we're "magically" passing some stuff into the commands we are running,
which are not explicit when looking at the commands being executed.
> A workaround would be to add a 'make shell' target, that drops you into
> an interactive shell. I don't really like it very much, but it would
> solve other issues with exported variables.
Not a big fan either :/
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-04 21:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 19:59 [Buildroot] [PATCH v5 0/4] PATH cleanup Samuel Martin
2014-03-01 19:59 ` [Buildroot] [PATCH v5 1/4] bustle: use TARGET_MAKE_ENV instead of setting PATH in the make environment Samuel Martin
2014-03-01 22:47 ` Thomas Petazzoni
2014-03-01 19:59 ` [Buildroot] [PATCH v5 2/4] Makefile: export PATH including the Buildroot host bindirs Samuel Martin
2014-03-04 17:06 ` Arnout Vandecappelle
2014-03-04 21:52 ` Thomas Petazzoni [this message]
2014-03-04 23:11 ` Samuel Martin
2014-03-01 19:59 ` [Buildroot] [PATCH v5 3/4] Makefile: add $(HOST_DIR)/sbin to the PATH Samuel Martin
2014-03-04 17:07 ` Arnout Vandecappelle
2014-03-01 19:59 ` [Buildroot] [PATCH v5 4/4] *.mk: remove all occurences of TARGET_PATH and HOST_PATH Samuel Martin
2014-03-04 17:19 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304225234.164382f9@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox