From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gst1-plugins-bad: add missing opencv ml module dependency
Date: Thu, 6 Mar 2014 11:31:47 +0100 [thread overview]
Message-ID: <20140306113147.2935873b@skate> (raw)
In-Reply-To: <53184691.40008@imgtec.com>
Dear Vicente Olivert Riera,
On Thu, 6 Mar 2014 09:57:37 +0000, Vicente Olivert Riera wrote:
> On 03/05/2014 10:55 PM, Samuel Martin wrote:
> > gst1-plugins-bad source code does include the old-style global opencv
> > header "opencv/cv.h", which includes headers from the core, imgproc,
> > video, features2d, flann, calib3d, objdetect and legacy modules.
> >
> > However, the legacy module, in addition to headers from some of the
> > previously listed modules, also includes headers from the ml module.
> >
> > Thus, the ml module must be selected to be able to build the legacy
> > one, so the gst-plugins-bad's opencv plugin.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
> >
> > Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> > ---
> > package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in
> > index 0685322..2c5c290 100644
> > --- a/package/gstreamer1/gst1-plugins-bad/Config.in
> > +++ b/package/gstreamer1/gst1-plugins-bad/Config.in
> > @@ -434,6 +434,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV
> > select BR2_PACKAGE_OPENCV_LIB_FLANN
> > select BR2_PACKAGE_OPENCV_LIB_IMGPROC
> > select BR2_PACKAGE_OPENCV_LIB_LEGACY
> > + select BR2_PACKAGE_OPENCV_LIB_ML
> > select BR2_PACKAGE_OPENCV_LIB_OBJDETECT
> > select BR2_PACKAGE_OPENCV_LIB_VIDEO
> > help
> >
>
> Maybe your BR tree wasn't up to date in the moment to write this patch.
> Look at this:
>
> http://git.buildroot.net/buildroot/commit/?id=3324f4e8b69ab49783a233b27c9b2edeecedb5ce
And? Samuel is just adding one more line here, in addition to the lines
you added in the commit you're pointing at.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-06 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 22:55 [Buildroot] [PATCH] gst1-plugins-bad: add missing opencv ml module dependency Samuel Martin
2014-03-06 9:57 ` Vicente Olivert Riera
2014-03-06 10:31 ` Thomas Petazzoni [this message]
2014-03-06 10:34 ` Vicente Olivert Riera
2014-03-06 10:35 ` Samuel Martin
2014-03-06 17:25 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306113147.2935873b@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox