From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] chdkptp CLI added
Date: Fri, 7 Mar 2014 23:50:55 +0100 [thread overview]
Message-ID: <20140307235055.494ef4e4@skate> (raw)
In-Reply-To: <1387798250-2437-2-git-send-email-matthew.j.urry@gmail.com>
Dear Matthew Urry,
On Mon, 23 Dec 2013 11:30:50 +0000, Matthew Urry wrote:
>
> Signed-off-by: Matthew Urry <matthew.j.urry@gmail.com>
> ---
> package/Config.in | 1 +
> package/chdkptp/Config.in | 15 +++++++++++
> .../chdkptp-01-add_lm_flag_to_makefile.patch | 15 +++++++++++
> ...ptp-02-create_sh_script_to_launch_chdkptp.patch | 22 ++++++++++++++++
> package/chdkptp/chdkptp.mk | 27 ++++++++++++++++++++
> 5 files changed, 80 insertions(+)
> create mode 100644 package/chdkptp/Config.in
> create mode 100644 package/chdkptp/chdkptp-01-add_lm_flag_to_makefile.patch
> create mode 100644 package/chdkptp/chdkptp-02-create_sh_script_to_launch_chdkptp.patch
> create mode 100644 package/chdkptp/chdkptp.mk
You received some review on this patch on December, 28th 2013,
suggesting several improvements to make your patch acceptable upstream.
Your contributions are definitely welcome, but if you want to get it
accepted, it'd be nice if you could resend a new version that takes
into account the comments that have been made.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-07 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 11:30 [Buildroot] [PATCH 0/1] chdkptp cli Matthew Urry
2013-12-23 11:30 ` [Buildroot] [PATCH 1/1] chdkptp CLI added Matthew Urry
2013-12-28 16:38 ` Thomas Petazzoni
2014-03-07 22:50 ` Thomas Petazzoni [this message]
2014-06-11 20:28 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307235055.494ef4e4@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox