From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] legal-info: extract even no-redistribute packages
Date: Mon, 17 Mar 2014 19:39:23 +0100 [thread overview]
Message-ID: <20140317183923.GA3393@free.fr> (raw)
In-Reply-To: <532738D7.3070304@lucaceresoli.net>
Luca, All,
On 2014-03-17 19:03 +0100, Luca Ceresoli spake thusly:
> Yann E. MORIN wrote:
> >From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >Currently, if a package is marked _REDISTRIBUTE = NO, then legal-info
> >will not try to extract it first.
[--SNIP--]
> I agree with this change, but still it still leave a corner case broken.
>
> For packages with _LICENSE_FILES defined and _REDISTRIBUTE = NO, if
> local or override is used, the tarball is extracted but no license
> files are copied.
>
> This is because code that copies the files (a little below) is inside
> an if chain that prevents any actions for local and overridden packages.
Ah yes, I mised that case. Thanks for spotting this.
I'll rework the patch.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-03-17 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 22:10 [Buildroot] [PATCH 0/2 v3] legal-info: extract packages to get license files (branch yem/legal) Yann E. MORIN
2014-03-14 22:10 ` [Buildroot] [PATCH 1/2] legal-info: extract even no-redistribute packages Yann E. MORIN
2014-03-17 18:03 ` Luca Ceresoli
2014-03-17 18:39 ` Yann E. MORIN [this message]
2014-03-14 22:10 ` [Buildroot] [PATCH 2/2] legal-info: add a comment about what pacakges we save the tarballs of Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317183923.GA3393@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox