From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support: properly check for bash as a dependency
Date: Tue, 18 Mar 2014 19:27:51 +0100 [thread overview]
Message-ID: <20140318192751.0b0caaab@skate> (raw)
In-Reply-To: <20140318165518.GA3342@free.fr>
Dear Yann E. MORIN,
On Tue, 18 Mar 2014 17:55:18 +0100, Yann E. MORIN wrote:
> > I'm definitely against that. My system has /bin/sh pointing to dash,
> > and Buildroot works fine. One of the thing that annoyed me in
> > OpenEmbedded was its requirements to have /bin/sh be bash.
> >
> > We clearly don't want that.
>
> I'm just fine with that. :-)
>
> But the current check is broken anyway, as all it checks is that the
> login shell of the user is bash.
>
> - if we want to work whith dash as the system shell, then the current
> check is unneeded;
>
> - if we want to work with dash as the system shell, we don't care what
> login shell the user is using, as we must also work when this is dash;
>
> - SHELL is not mandated by POSIX, so it may be empty on a
> POSIX-compliant shell anyway.
>
> So, we should just remove this check altogether.
Yes, I agree.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-18 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 10:42 [Buildroot] [PATCH] support: properly check for bash as a dependency Yann E. MORIN
2014-03-17 21:28 ` Peter Korsgaard
2014-03-17 21:36 ` Yann E. MORIN
2014-03-17 22:01 ` Peter Korsgaard
2014-03-18 5:01 ` Thomas Petazzoni
2014-03-18 16:55 ` Yann E. MORIN
2014-03-18 18:27 ` Thomas Petazzoni [this message]
2014-03-20 20:43 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318192751.0b0caaab@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox