Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support: do not depend on bash
Date: Tue, 18 Mar 2014 23:45:01 +0100	[thread overview]
Message-ID: <20140318224501.GC26810@free.fr> (raw)
In-Reply-To: <87siqfw32l.fsf@dell.be.48ers.dk>

Peter, All,

On 2014-03-18 23:32 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> 
>  > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>  > We do want to work properly whatever the system shell or the
>  > user's login shell are.
> 
>  > The current check is anyway broken, as it only checks if the
>  > user's login shell is bash, not what the system shell is.
> 
>  > Remove the check altogether, since it is unneeded, and broken.
> 
> But we (currently atleast) do want bash for our own Makefiles (see
> toplevel Makefile). I'm not sure we're completely bashism-free (or if it
> is worth the trouble to be so).

OK, but then the check is jsut borked, since it does not check that basj
is isntalled on the system.

Notes:
  - SHELL is set in the environment by the login shell;
  - if one has bash as login shell, but sub-sequently runs dash, dahs
    does not reset SHELL and does not set it; instead, it uses the value
    that was pre-exisiting in the environment when it was launched.

So, all the current shell tests is whether the user's login shell is bash.

If instead we want to check that we do have bash installed on the
system, we need to fix the test.

As it is now, it is only confusing.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2014-03-18 22:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 20:17 [Buildroot] [PATCH] support: do not depend on bash Yann E. MORIN
2014-03-18 22:32 ` Peter Korsgaard
2014-03-18 22:45   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140318224501.GC26810@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox