Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/2] libubox: new package
Date: Tue, 18 Mar 2014 23:30:03 +0100	[thread overview]
Message-ID: <20140318233003.779610f2@skate> (raw)
In-Reply-To: <1395172899-3799-1-git-send-email-yegorslists@googlemail.com>

Dear Yegor Yefremov,

On Tue, 18 Mar 2014 21:01:38 +0100, Yegor Yefremov wrote:

> +LIBUBOX_VERSION = bbd846ec2d72b2629758b69dc122ac0b0f2c3e4b
> +LIBUBOX_SITE = git://nbd.name/luci2/libubox.git
> +LIBUBOX_LICENSE = LGPLv2.1, GPLv2, BSD-3c, MIT
> +LIBUBOX_INSTALL_STAGING = YES
> +
> +ifeq ($(BR2_PACKAGE_LUA),y)
> +	LIBUBOX_DEPENDENCIES = lua
> +	LIBUBOX_MAKE_ENV = \
> +		PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)"	\
> +		PKG_CONFIG_PATH="$(STAGING_DIR)/usr/lib/pkgconfig"

No. These variables should I believe not be necessary. The
cmake-package infrastructure should simply use PATH=$(TARGET_PATH) so
that when a CMake package is built, $(HOST_DIR)/usr/bin/pkg-config is
used, and this pkg-config variant already knows the right path and
sysroot for the .pc files.

I believe Samuel Martin has already sent a patch doing this for the
CMake package infrastructure.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-03-18 22:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 20:01 [Buildroot] [PATCH v3 1/2] libubox: new package Yegor Yefremov
2014-03-18 20:01 ` [Buildroot] [PATCH v3 2/2] libuci: " Yegor Yefremov
2014-03-18 22:30 ` Thomas Petazzoni [this message]
2014-03-19 11:00   ` [Buildroot] [PATCH v3 1/2] libubox: " Yegor Yefremov
2014-03-19 11:29     ` Samuel Martin
2014-03-19 11:58       ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140318233003.779610f2@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox