Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] bluez5_utils: new package.
Date: Thu, 20 Mar 2014 19:21:44 +0100	[thread overview]
Message-ID: <20140320192144.2c53f07a@skate> (raw)
In-Reply-To: <1395323298-15098-1-git-send-email-marcin@bis.org.pl>

Dear Marcin Bis,

On Thu, 20 Mar 2014 14:48:18 +0100, Marcin Bis wrote:

> The patch follows:

Thanks a lot, but the patch should be in a separate e-mail. As you sent
it, all your discussion answering Yann's comment would end up in the
patch commit log.

> bluez5_utils: new package.
> 
> API is not backwards compatible with BlueZ 4.
> 
> BlueZ utils will use systemd and/or udev if enabled.
> Contains a hook for installing GATT support tool, wchich is always
> build but not installed by default.

Also your Signed-off-by line is missing.

See
http://buildroot.org/downloads/manual/manual.html#_contributing_to_buildroot
for more details about formatting patches.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-03-20 18:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04 12:59 [Buildroot] [PATCH] bluez5_utils: new package Marcin Bis
2013-11-04 16:06 ` Thomas De Schampheleire
2013-11-04 21:34   ` [Buildroot] [PATCH v2] " Marcin Bis
2014-03-04 21:38     ` Yann E. MORIN
2014-03-20 13:48       ` [Buildroot] [PATCH v3] " Marcin Bis
2014-03-20 18:21         ` Thomas Petazzoni [this message]
2014-03-20 19:28         ` Jerzy Grzegorek
2014-03-21  9:48           ` Marcin Bis
2014-03-21  9:53           ` [Buildroot] [PATCH v4] " Marcin Bis
2014-03-21 11:08             ` Jerzy Grzegorek
2014-03-21 11:42               ` Gustavo Zacarias
2014-03-21 16:45                 ` Jerzy Grzegorek
2014-03-21 16:50                   ` Gustavo Zacarias
2014-03-23 23:10                     ` Jerzy Grzegorek
2014-03-31  8:55                       ` Marcin Bis
2014-03-31  8:58                       ` [Buildroot] [PATCH v5] " Marcin Bis
2014-04-03 20:00                         ` Thomas Petazzoni
2014-04-04  9:03                           ` Marcin Bis
2014-08-02 11:08                         ` Thomas Petazzoni
2014-03-21 16:55                   ` [Buildroot] [PATCH v4] " Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140320192144.2c53f07a@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox