From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Different site methods for the main package and patches
Date: Wed, 26 Mar 2014 23:37:12 +0100 [thread overview]
Message-ID: <20140326233712.4347c3c8@skate> (raw)
In-Reply-To: <53331268.4030205@mind.be>
Dear Arnout Vandecappelle,
On Wed, 26 Mar 2014 18:46:16 +0100, Arnout Vandecappelle wrote:
> You're probably right about that. The problem is that the DOWNLOAD macro
> cannot know if it is given a patch or the package itself. So it should
> probably be changed to get _SITE_METHOD as an optional argument.
>
> Yann, perhaps you could take that up into your download method rework
> series?
Generally speaking, I'm a bit unhappy about how things work on the
download front:
*) I don't really understand why we have a separation between _SITE
and _SOURCE, and why our infra assumes that _PATCH is relative to
_SITE. Why don't we simply make _SOURCE and _PATCH full URLs
instead? This way _PATCH can list multiple patches coming from
different locations, not necessarily the upstream location of the
package.
*) Why is the DOWNLOAD macro looking at _SITE_METHOD ? It believe it
should be a macro that remains independent of the package
infrastructure, and it should simply take as argument the
information that it needs, rather than poking directly into
_SITE_METHOD.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-26 22:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 0:47 [Buildroot] Different site methods for the main package and patches Frank Hunleth
2014-03-26 17:46 ` Arnout Vandecappelle
2014-03-26 22:37 ` Thomas Petazzoni [this message]
2014-03-26 22:42 ` Peter Korsgaard
2014-03-26 23:00 ` rjbarnet at rockwellcollins.com
2014-03-26 23:26 ` Thomas Petazzoni
2014-03-26 23:34 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140326233712.4347c3c8@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox