From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/6] python-m2crypto: requires host-python2
Date: Sat, 29 Mar 2014 12:51:58 +0100 [thread overview]
Message-ID: <20140329115158.GH3227@free.fr> (raw)
In-Reply-To: <1394057085-10399-6-git-send-email-s.martin49@gmail.com>
Samuel, All,
On 2014-03-05 23:04 +0100, Samuel Martin spake thusly:
> Acording to its homepage [1], m2crypto does not support python3 yet.
>
> So, this patch forces building the host m2crypto module for pyhton2.
>
> [1] https://pypi.python.org/pypi/M2Crypto
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewd-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
If the variable gets renamed, my reviewed-by still stands.
Regards,
Yann E. MORIN.
> ---
> package/python-m2crypto/python-m2crypto.mk | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/package/python-m2crypto/python-m2crypto.mk b/package/python-m2crypto/python-m2crypto.mk
> index dd0f77e..62dc720 100644
> --- a/package/python-m2crypto/python-m2crypto.mk
> +++ b/package/python-m2crypto/python-m2crypto.mk
> @@ -10,12 +10,16 @@ PYTHON_M2CRYPTO_SOURCE = M2Crypto-$(PYTHON_M2CRYPTO_VERSION).tar.gz
> PYTHON_M2CRYPTO_SETUP_TYPE = setuptools
> HOST_PYTHON_M2CRYPTO_DEPENDENCIES = host-openssl host-swig
>
> -# We need to override the build commands to be able to use build_ext,
> -# which accepts the --openssl option.
> +# We need to use python2 because m2crypto is not python3 compliant.
> +HOST_PYTHON_M2CRYPTO_FORCE_HOST_PYTHON = python2
> +
> +# * We need to override the build commands to be able to use build_ext,
> +# which accepts the --openssl option.
> +# * Use python2 interpreter to avoid trying building some python3 objects.
> define HOST_PYTHON_M2CRYPTO_BUILD_CMDS
> (cd $(@D); \
> $(HOST_PKG_PYTHON_SETUPTOOLS_ENV) \
> - $(HOST_DIR)/usr/bin/python setup.py build_ext \
> + $(HOST_DIR)/usr/bin/python2 setup.py build_ext \
> --openssl=$(HOST_DIR)/usr)
> endef
>
> --
> 1.9.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-03-29 11:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 22:04 [Buildroot] [PATCH 0/6] host-python2 hard dependency Samuel Martin
2014-03-05 22:04 ` [Buildroot] [PATCH 1/6] python: rework python symlinks installation Samuel Martin
2014-03-29 11:05 ` Yann E. MORIN
2014-03-05 22:04 ` [Buildroot] [PATCH 2/6] python3: " Samuel Martin
2014-03-29 11:23 ` Yann E. MORIN
2014-03-05 22:04 ` [Buildroot] [PATCH 3/6] pkg-python: support host-python dependency different from the python in the target Samuel Martin
2014-03-29 11:47 ` Yann E. MORIN
2014-03-29 13:26 ` Thomas Petazzoni
2014-03-29 13:58 ` Yann E. MORIN
2014-03-05 22:04 ` [Buildroot] [PATCH 4/6] scons: force host-python dependency to be python2 Samuel Martin
2014-03-29 11:50 ` Yann E. MORIN
2014-03-05 22:04 ` [Buildroot] [PATCH 5/6] python-m2crypto: requires host-python2 Samuel Martin
2014-03-29 11:51 ` Yann E. MORIN [this message]
2014-03-05 22:04 ` [Buildroot] [PATCH 6/6] crda: override python interperter Samuel Martin
2014-03-29 11:56 ` Yann E. MORIN
2014-04-05 15:42 ` [Buildroot] [PATCH 0/6] host-python2 hard dependency Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140329115158.GH3227@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox