Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] wget: fix autoreconf brokeness
Date: Thu, 3 Apr 2014 17:03:15 +0300	[thread overview]
Message-ID: <20140403140315.GK4579@tarshish> (raw)
In-Reply-To: <1396532611-30218-2-git-send-email-gustavo@zacarias.com.ar>

Hi Gustavo,

On Thu, Apr 03, 2014 at 10:43:31AM -0300, Gustavo Zacarias wrote:
> Fix failed AUTORECONF under certain circumstances where gettext infra is
> much newer (>= 0.18) than what wget source expects (~ 0.17).
> Do this by gettextizing the source before AUTORECONFing.
> If this becomes common we may need a FOO_GETTEXTIZE generic option, but
> for now this seems to be the only package that needs so. Fixes:
> http://autobuild.buildroot.net/results/c0f/c0f7c801f61fdc310cde64342060b00a70155431/
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Tested-by: Baruch Siach <baruch@tkos.co.il>

Thanks,
baruch

> ---
>  package/wget/wget.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/package/wget/wget.mk b/package/wget/wget.mk
> index 80f8314..f3a5274 100644
> --- a/package/wget/wget.mk
> +++ b/package/wget/wget.mk
> @@ -13,6 +13,14 @@ WGET_LICENSE_FILES = COPYING
>  # patching gnulib .m4 file
>  WGET_AUTORECONF = YES
>  
> +# Ugly kludge to fix autoreconf with old gettext infra
> +# We need to gettextize before autoreconf to upgrade
> +WGET_DEPENDENCIES += host-gettext
> +define WGET_GETTEXTIZE
> +	cd $(@D) ; $(HOST_DIR)/usr/bin/gettextize -f
> +endef
> +WGET_POST_PATCH_HOOKS += WGET_GETTEXTIZE
> +
>  # Prefer full-blown wget over busybox
>  ifeq ($(BR2_PACKAGE_BUSYBOX),y)
>  	WGET_DEPENDENCIES += busybox

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2014-04-03 14:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 13:43 [Buildroot] [PATCH 1/2] gettext: make host gettextize non-interactive Gustavo Zacarias
2014-04-03 13:43 ` [Buildroot] [PATCH 2/2] wget: fix autoreconf brokeness Gustavo Zacarias
2014-04-03 14:03   ` Baruch Siach [this message]
2014-04-03 18:13 ` [Buildroot] [PATCH 1/2] gettext: make host gettextize non-interactive Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140403140315.GK4579@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox