Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] valgrind: remove default flags -mips32 and -mips64 from Makefile.all.am
Date: Thu, 3 Apr 2014 21:31:04 +0200	[thread overview]
Message-ID: <20140403213104.45507785@skate> (raw)
In-Reply-To: <1396267805-11978-1-git-send-email-Vincent.Riera@imgtec.com>

Dear Vicente Olivert Riera,

Thanks, I've applied your patch. One small comment below.

On Mon, 31 Mar 2014 13:10:05 +0100, Vicente Olivert Riera wrote:
> During configuration of Valgrind we check does the compiler support
> -march=mips32 and -march=mips64. If compiler supports these flags we are
> using them as default flags for mips32 and mips64.
> 
> "VALGRIND_AUTORECONF = YES" needs to be added to valgrind.mk because
> this patch modifies the configure.ac.
> 
> Original upstream patch:
>    https://github.com/svn2github/valgrind/commit/fdf6c5aea4671c3c43c90230510735d215dd1e1c

This information should also have been part of the patch itself, so
that the next time we bump Valgrind and look at the patches, it is
clear that this patch is already upstream. I've done that before
applying your patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-04-03 19:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 12:10 [Buildroot] [PATCH] valgrind: remove default flags -mips32 and -mips64 from Makefile.all.am Vicente Olivert Riera
2014-04-03 19:31 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140403213104.45507785@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox