From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] postgresql: new package
Date: Thu, 3 Apr 2014 22:39:52 +0200 [thread overview]
Message-ID: <20140403223952.37034a1a@skate> (raw)
In-Reply-To: <1396249169-14126-1-git-send-email-ps.report@gmx.net>
Dear Peter Seiderer,
On Mon, 31 Mar 2014 08:59:29 +0200, Peter Seiderer wrote:
> diff --git a/package/postgresql/Config.in b/package/postgresql/Config.in
> new file mode 100644
> index 0000000..bc0305b
> --- /dev/null
> +++ b/package/postgresql/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_POSTGRESQL
> + bool "PostgreSQL"
lower case, please.
> + depends on BR2_INET_IPV6
Since it currently doesn't build with uClibc, can you make this package
depends on !BR2_TOOLCHAIN_USES_UCLIBC ?
> +if [ ! -f /srv/pgsql/data/PG_VERSION ]; then
I thought we changed to /var/lib/pgsql ?
Maybe you should create a variable that contains /var/lib/pgsql to
avoid this duplication.
> +ifeq ($(BR2_PACKAGE_ZLIB),y)
> + POSTGRESQL_DEPENDENCIES += zlib
> +else
> + POSTGRESQL_CONF_OPT += --wihtout-zlib
Typo.
> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> + POSTGRESQL_DEPENDENCIES += openssl
> + POSTGRESQL_CONF_OPT += --with-openssl
else
POSTGRESQL_CONF_OPT += --without-openssl
Other than that, looks good.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-03 20:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 6:59 [Buildroot] [PATCH] postgresql: new package Peter Seiderer
2014-04-03 20:39 ` Thomas Petazzoni [this message]
2014-04-04 6:04 ` Arnout Vandecappelle
2014-04-04 19:15 ` Peter Seiderer
2014-04-03 21:55 ` Jerzy Grzegorek
2014-04-04 19:18 ` Peter Seiderer
-- strict thread matches above, loose matches on Subject: below --
2014-03-18 20:56 Peter Seiderer
2014-03-08 21:59 Peter Seiderer
2014-03-16 12:15 ` Marco Trapanese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403223952.37034a1a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox