From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Date: Thu, 10 Apr 2014 07:39:51 +0300 Subject: [Buildroot] [PATCH] ne10: bump version to 1.0.0 In-Reply-To: References: <99baf8d8d8d05b5f2de390deef6546acab0199dd.1396965306.git.baruch@tkos.co.il> Message-ID: <20140410043951.GS4096@tarshish> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Samuel, On Wed, Apr 09, 2014 at 06:11:43AM +0200, Samuel Martin wrote: > On Tue, Apr 8, 2014 at 3:55 PM, Baruch Siach wrote: > > Switch to github helper while at it. > > > > Fixes: > > http://autobuild.buildroot.net/results/a2c/a2ca3fe245e410a738f4b10631a1414696a0edea/ > > > > Signed-off-by: Baruch Siach > > --- > > ...CMakeLists.txt-add-neon-support-to-CFLAGS.patch | 31 ++++++++++++++++++++++ > > package/ne10/ne10.mk | 10 +++---- > > 2 files changed, 36 insertions(+), 5 deletions(-) > > create mode 100644 package/ne10/ne10-01-CMakeLists.txt-add-neon-support-to-CFLAGS.patch > > > > diff --git a/package/ne10/ne10-01-CMakeLists.txt-add-neon-support-to-CFLAGS.patch b/package/ne10/ne10-01-CMakeLists.txt-add-neon-support-to-CFLAGS.patch > > new file mode 100644 > > index 000000000000..1777de102328 > > --- /dev/null > > +++ b/package/ne10/ne10-01-CMakeLists.txt-add-neon-support-to-CFLAGS.patch > > @@ -0,0 +1,31 @@ > > +From 1ab64866615643d19a8e5c4f1a3f62f1baad6e83 Mon Sep 17 00:00:00 2001 > > +Message-Id: <1ab64866615643d19a8e5c4f1a3f62f1baad6e83.1396964788.git.baruch@tkos.co.il> > > +From: Baruch Siach > > +Date: Tue, 8 Apr 2014 16:40:28 +0300 > > +Subject: [PATCH] CMakeLists.txt: add neon support to CFLAGS > > + > > +Fixed build failure: > > + > > +.../include/arm_neon.h:32:2: error: #error You must enable NEON instructions (e.g. -mfloat-abi=softfp -mfpu=neon) to use arm_neon.h > > + > > +Signed-off-by: Baruch Siach > > +--- > > + CMakeLists.txt | 2 +- > > + 1 file changed, 1 insertion(+), 1 deletion(-) > > + > > +diff --git a/CMakeLists.txt b/CMakeLists.txt > > +index e5a98af53c1f..22ce166650da 100644 > > +--- a/CMakeLists.txt > > ++++ b/CMakeLists.txt > > +@@ -78,7 +78,7 @@ if(ANDROID_PLATFORM) > > + add_subdirectory(android/NE10Demo/jni) > > + endif() > > + elseif(GNULINUX_PLATFORM) > > +- set(CMAKE_C_FLAGS "-O2 -mthumb-interwork -mthumb -march=armv7-a -mfpu=vfp3") > > ++ set(CMAKE_C_FLAGS "-O2 -mthumb-interwork -mthumb -march=armv7-a -mfloat-abi=softfp -mfpu=neon") > > + set(CMAKE_ASM_FLAGS "-mthumb-interwork -mthumb -march=armv7-a -mfpu=neon") > > + elseif(IOS_PLATFORM) > > + #set minimal target ios version.If not provided this option, Xcode > > I clearly don't like this patch, so I nack it. I don't like it either. > [...] > > Instead of messing the CMAKE_C_FLAGS in the package build system > itself for something related to the target, I suggest to do this logic > in the Buildroot ne10.mk. > > I mean, the toolchainfile.cmake allows you to pass some CFLAGS because it does: > set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -pipe -Os ... " CACHE STRING > "Buildroot CFLAGS" FORCE) But toolchainfile.cmake is a global file, it doesn't change per package. > So you can add the logic adjusting the -mfloat-abi=... and -mfpu=... > in the ne10.mk: > NE10_CONF_OPT += > -DCMAKE_C_FLAGS="-mfloat-abi=$(BR2_GCC_TARGET_FLOAT_ABI) > -mfpu=$(BR2_GCC_TARGET_FPU)" A quick test shows that this solution doesn't work. Just added: NE10_CONF_OPT += "-DCMAKE_C_FLAGS=-O2 -mthumb-interwork -mthumb \ -march=armv7-a -mfloat-abi=softfp -mfpu=neon" instead of patching, and got the same failure. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -