Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] systemd: Build legacy pc files when liblogging is
Date: Thu, 10 Apr 2014 19:50:34 +0200	[thread overview]
Message-ID: <20140410175032.GA24213@pc-eric> (raw)
In-Reply-To: <1397145566-11243-1-git-send-email-Vincent.Riera@imgtec.com>

Hi!

On Thu, Apr 10, 2014 at 04:59:25PM +0100, Vicente Olivert Riera wrote:
[...]
> Passing the "--enable-compat-libs" option to the systemd configure
> script will install the separate libraries and ".pc" files, so we add
> that option just in case the liblogging package had been selected.  We
> can revert this change when liblogging upstream fixes it's configure
> script to check for "libsystemd.pc" instead of "libsystemd-journal.pc".

Maybe some other packages depend on these compatibility libraries, so instead
of referring to BR2_PACKAGE_LIBLOGGING in systemd.mk, it would be best to add
a generic configuration option to systemd, as done for berkeleydb with
BR2_PACKAGE_BERKELEYDB_COMPAT185. It could be named BR2_PACKAGE_SYSTEMD_COMPAT.

Then, in package/liblogging/Config.in, we would have:

  select BR2_PACKAGE_SYSTEMD_COMPAT if BR2_INIT_SYSTEMD

And this would be removed when liblogging is fixed upstream.

What do think of this?

Best regards,
ELB

  parent reply	other threads:[~2014-04-10 17:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 15:59 [Buildroot] [PATCH 1/2] systemd: Build legacy pc files when liblogging is Vicente Olivert Riera
2014-04-10 15:59 ` [Buildroot] [PATCH 2/2] liblogging: Depend on systemd Vicente Olivert Riera
2014-04-10 21:17   ` Peter Korsgaard
2014-04-10 17:50 ` Eric Le Bihan [this message]
2014-04-10 21:18   ` [Buildroot] [PATCH 1/2] systemd: Build legacy pc files when liblogging is Peter Korsgaard
2014-04-11  8:51     ` Vicente Olivert Riera
2014-04-14  9:35       ` Eric Le Bihan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140410175032.GA24213@pc-eric \
    --to=eric.le.bihan.dev@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox