Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/3] [RFC] pkg-autotools: introduce infra to gettextize packages (branch yem/gettextize)
Date: Thu, 10 Apr 2014 23:19:19 +0200	[thread overview]
Message-ID: <20140410231919.2538fac1@skate> (raw)
In-Reply-To: <cover.1397081821.git.yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On Thu, 10 Apr 2014 00:20:00 +0200, Yann E. MORIN wrote:

> This small series introduces the gettextize of a package as an optional
> sequence in the autotools package infra.
> 
>     WARNING! Completely untested, only an RFC!
> 
> Currently, wget is the sole user, and the way it is done for wget is
> just working by chance (see commit log of path 3 for the complete
> explanations.)
> 
> So, move the gettextization to the pkg-autotools infra, so we have a
> chance to do it correctly and consistently across packages.

I haven't looked at the details. But to me, when only one package needs
something, it is *way* too early to make changes to the common
infrastructure. Especially when there is a solution that allows to
solve the problem by making changes to the package .mk file itself.

I believe changes to the package infrastructure should only be made
when:

 * There is really no solution to solve the particular problem at the
   package .mk file level;

 * There are a sufficient (say 5 or 10 maybe) packages that have a
   similar problem, and therefore factorization would make sense.

So far, I don't really see a compelling reason to complexity the
package infrastructure just for the need of one particular package.
Need that may very well be transient, because a future bump of wget
will most likely remove the need for the gnulib patch, therefore for
the autoreconf.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2014-04-10 21:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 22:20 [Buildroot] [PATCH 0/3] [RFC] pkg-autotools: introduce infra to gettextize packages (branch yem/gettextize) Yann E. MORIN
2014-04-09 22:20 ` [Buildroot] [PATCH 1/3] pkg-autotools: add support to gettextize a package Yann E. MORIN
2014-04-09 22:20 ` [Buildroot] [PATCH 2/3] manual: add gettextize explanations in the manual Yann E. MORIN
2014-04-10  8:34   ` Thomas De Schampheleire
2014-04-09 22:20 ` [Buildroot] [PATCH 3/3] package/wget: use the new gettextize infra Yann E. MORIN
2014-04-10  3:34   ` Baruch Siach
2014-04-10  5:12     ` Yann E. MORIN
2014-04-10 21:19 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140410231919.2538fac1@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox