From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Le Bihan Date: Mon, 14 Apr 2014 11:35:46 +0200 Subject: [Buildroot] [PATCH 1/2] systemd: Build legacy pc files when liblogging is In-Reply-To: <5347ACFD.907@imgtec.com> References: <1397145566-11243-1-git-send-email-Vincent.Riera@imgtec.com> <20140410175032.GA24213@pc-eric> <87lhvc6fzf.fsf@dell.be.48ers.dk> <5347ACFD.907@imgtec.com> Message-ID: <20140414093546.GB5385@pc-eric> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Fri, Apr 11, 2014 at 09:51:09AM +0100, Vicente Olivert Riera wrote: > On 04/10/2014 10:18 PM, Peter Korsgaard wrote: > >>>>>>"Eric" == Eric Le Bihan writes: > > > >Hi, > > > > > Maybe some other packages depend on these compatibility libraries, so instead > > > of referring to BR2_PACKAGE_LIBLOGGING in systemd.mk, it would be best to add > > > a generic configuration option to systemd, as done for berkeleydb with > > > BR2_PACKAGE_BERKELEYDB_COMPAT185. It could be named BR2_PACKAGE_SYSTEMD_COMPAT. > > > > > Then, in package/liblogging/Config.in, we would have: > > > > > select BR2_PACKAGE_SYSTEMD_COMPAT if BR2_INIT_SYSTEMD > > > > > And this would be removed when liblogging is fixed upstream. > > > >Yes, I agree. > > > > > What do think of this? > > > >Care to send an updated patch series doing that? > > > > I didn't do that in purpose, because I thought it would be a good > idea to catch those packages that still look for legacy systemd > files, so we could tell upstream about that, as I did for > liblogging. I posted an implementation of BR2_PACKAGE_SYSTEMD_COMPAT. If other packages depend on the old libsystemd-*.so, I think this will allow us to catch them too, as they will not select this new symbol yet. > > If we put that option as a generic one, then we will never remove it > from there and we will be using the not-default systemd config > forever. As a reminder, I added a comment in the log about this. Best regards, ELB