Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [[PATCH v2] 1/1] lttng-libust: Disable liblttng-ust-dl with uClibc.
Date: Mon, 14 Apr 2014 22:42:06 +0200	[thread overview]
Message-ID: <20140414224206.078f43a4@skate> (raw)
In-Reply-To: <1397426422-6193-1-git-send-email-romain.naour@openwide.fr>

Dear Romain Naour,

On Mon, 14 Apr 2014 00:00:22 +0200, Romain Naour wrote:
> According to uClibc commit [1], dlinfo is not available in recent uClibc (>0.9.33),
> but is available in older version of uClibc (<=0.9.33) whith a different prototype
> than dlinfo() in glibc.
> 
> To be able to use LTTng UST with uClibc, we need to disable the Dynamic Linker
> Tracing functionality [2].
> 
> A specific test on dlinfo() prototype is performed to enable or disable this
> functionality.
> 
> This patch supersede the one added in abf58f46cedacace1db53de5cc12a8fe9f7fbd82
> that wrongly disable liblttng-ust-dl even if dlinfo() comme from glibc.
> 
> Fixes:
> http://autobuild.buildroot.net/results/a6c/a6c33dd7ec2a36a50c5ea74b989a371d6c85e899/build-end.log
> 
> [1] http://git.uclibc.org/uClibc/commit/?id=f3c9dc499c5c787ddd8c4320f2d44d2ae6e40c22
> [2] http://lists.lttng.org/pipermail/lttng-dev/2014-February/022423.html
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Applied, thanks. However, I had to fix up the title of your patch.
Please don't screw it up like this, and just use:

	git format-patch --subject-prefix="PATCH v2"

and no other weird thing. Your patch title should have brackets inside
brackets, i.e the title should look like:

	[PATCH v2 1/1] lttng-libust...

or even better, for a single patch:

	[PATCH v2] lttng-libust...

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-04-14 20:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-13 22:00 [Buildroot] [[PATCH v2] 1/1] lttng-libust: Disable liblttng-ust-dl with uClibc Romain Naour
2014-04-14 20:42 ` Thomas Petazzoni [this message]
2014-04-15 20:11   ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140414224206.078f43a4@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox