From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/4] Makefile: fix coding style
Date: Wed, 16 Apr 2014 19:42:15 +0200 [thread overview]
Message-ID: <20140416194215.7d3151fa@skate> (raw)
In-Reply-To: <1396864610-8426-2-git-send-email-fabio.porcedda@gmail.com>
Dear Fabio Porcedda,
On Mon, 7 Apr 2014 11:56:47 +0200, Fabio Porcedda wrote:
> As stated in the buildroot user manual add just a single space before
> and after a '=' sign.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
> Makefile | 184 +++++++++++++++++++++++++++++++--------------------------------
> 1 file changed, 92 insertions(+), 92 deletions(-)
To be honest, while I definitely value the change to harmonize the
coding style, such a large patch touching almost every line of the main
Makefile is a recipe for conflicts with many other patches. So I would
personally prefer to not apply this patch, and do the coding style
fixes progressively, as we make other changes to the main Makefile.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-16 17:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 9:56 [Buildroot] [PATCH v4 0/4] Miscellauneus patches Fabio Porcedda
2014-04-07 9:56 ` [Buildroot] [PATCH v4 1/4] Makefile: fix coding style Fabio Porcedda
2014-04-16 17:42 ` Thomas Petazzoni [this message]
2014-04-17 8:21 ` Fabio Porcedda
2014-04-22 16:03 ` Arnout Vandecappelle
2014-04-22 20:16 ` Thomas Petazzoni
2014-04-22 20:28 ` Fabio Porcedda
2014-04-23 8:43 ` Fabio Porcedda
2014-04-07 9:56 ` [Buildroot] [PATCH v4 2/4] toolchain: add a hidden config option to enable the toolchain package Fabio Porcedda
2014-04-16 17:43 ` Thomas Petazzoni
2014-04-17 8:10 ` Fabio Porcedda
2014-04-07 9:56 ` [Buildroot] [PATCH v4 3/4] Makefile: let show-targets prints also the dependencies Fabio Porcedda
2014-04-16 17:49 ` Thomas Petazzoni
2014-04-17 9:17 ` Fabio Porcedda
2014-04-22 10:15 ` Fabio Porcedda
2014-04-23 8:46 ` Fabio Porcedda
2014-04-07 9:56 ` [Buildroot] [PATCH v4 4/4] luajit: needs for 32bit archictectures a 32bit host gcc Fabio Porcedda
2014-04-16 17:54 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416194215.7d3151fa@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox