From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 16 Apr 2014 20:00:50 +0200 Subject: [Buildroot] [PATCH 03/13] package/mesa3d: fix improper dependency of blind option In-Reply-To: <84c5268994e965fac056f5de485a99ea8baa4840.1396699629.git.yann.morin.1998@free.fr> References: <84c5268994e965fac056f5de485a99ea8baa4840.1396699629.git.yann.morin.1998@free.fr> Message-ID: <20140416200050.3a933a5d@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Yann E. MORIN, On Sat, 5 Apr 2014 14:10:07 +0200, Yann E. MORIN wrote: > From: "Yann E. MORIN" > > Currently, the blind option BR2_PACKAGE_MESA3D_DRI_DRIVER depends > on !STATIC. > > But this option is also selected by the various DRI drivers, and > none of them currently depend on !STATIC (although there is a comment > stating DRI drivers need !STATIC, there's nothing to enforce that). > > So, we could well end-up with an inconsistent configuration, where some > DRI drivers are selected even though STATIC is set. > > Enclose all DRI drivers in an 'if !STATIC' condition, remove the > dependency from the blind option, move the comment so it is nearer > the affected drivers, rephrase the comment to match the rules about > dependencies on toolchain features. > > Signed-off-by: "Yann E. MORIN" > Cc: Paul Cercueil > Cc: Bernd Kuhls > --- > package/mesa3d/Config.in | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) Thanks, applied, with one minor nit, see below. > +comment "DRI drivers need dynamic library" > + depends on BR2_PREFER_STATIC_LIB This is not the correct wording according to the manual, it should have been: comment "DRI drivers need a toolchain w/ dynamic library" Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com