From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-cmaketargets.mk: do not hardcode absolute path in toolchainfile.cmake
Date: Sat, 19 Apr 2014 23:59:45 +0200 [thread overview]
Message-ID: <20140419235945.0601cc38@skate> (raw)
In-Reply-To: <531429C3.80801@mind.be>
Samuel,
On Mon, 03 Mar 2014 08:05:39 +0100, Arnout Vandecappelle wrote:
> > $(HOST_DIR)/usr/share/buildroot/toolchainfile.cmake:
> > @mkdir -p $(@D)
> > @echo -en "\
> > + get_filename_component(_HOST_DIR \$${CMAKE_CURRENT_LIST_FILE} PATH)\n\
> > + set(_HOST_DIR \"\$${_HOST_DIR}/../../..\")\n\
> > set(CMAKE_SYSTEM_NAME Linux)\n\
> > - set(CMAKE_C_COMPILER $(TARGET_CC_NOCCACHE))\n\
> > - set(CMAKE_CXX_COMPILER $(TARGET_CXX_NOCCACHE))\n\
> > + set(CMAKE_C_COMPILER \"\$${_HOST_DIR}/$(subst $(HOST_DIR)/,,$(TARGET_CROSS))gcc\")\n\
>
> Wouldn't it be more natural to write
>
> set(CMAKE_C_COMPILER \"$(subst $(HOST_DIR)/,\$${_HOST_DIR}/,$(TARGET_CC_NOCCACHE)\")\n\
>
> ?
Can you reply to Arnout comment, and/or resend an updated version of
this patch? Or take some other action about it?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-19 21:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 17:16 [Buildroot] [PATCH] pkg-cmaketargets.mk: do not hardcode absolute path in toolchainfile.cmake Samuel Martin
2014-03-03 7:05 ` Arnout Vandecappelle
2014-04-19 21:59 ` Thomas Petazzoni [this message]
2014-04-20 8:57 ` Samuel Martin
2014-04-20 9:04 ` Samuel Martin
2014-04-22 16:55 ` Arnout Vandecappelle
2014-04-22 23:35 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140419235945.0601cc38@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox