Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Added support for linux headers for testing versions to build cross-compile tools
Date: Sun, 20 Apr 2014 11:07:24 +0200	[thread overview]
Message-ID: <20140420110724.5981255d@skate> (raw)
In-Reply-To: <1393334528-10441-1-git-send-email-lucas.zampar@gmail.com>

Dear Lucas Zampar Bernardi,

On Tue, 25 Feb 2014 10:22:08 -0300, Lucas Zampar Bernardi wrote:
> From: Lucas Zampar Bernardi <lucas@writesys.com.br>
> 
> 
> This patch add support to buildroot compile an internal cross-compiler using linux hearders with releases candidates versions (testing).
> ---
>  package/linux-headers/linux-headers.mk |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/linux-headers/linux-headers.mk b/package/linux-headers/linux-headers.mk
> index 086e5d5..d6e9dbb 100644
> --- a/package/linux-headers/linux-headers.mk
> +++ b/package/linux-headers/linux-headers.mk
> @@ -13,6 +13,12 @@ LINUX_HEADERS_SITE = $(BR2_KERNEL_MIRROR)/linux/kernel/v2.6/
>  else
>  LINUX_HEADERS_SITE = $(BR2_KERNEL_MIRROR)/linux/kernel/v3.x/
>  endif
> +
> +# release candidates are in testing/ subdir
> +ifneq ($(findstring -rc,$(LINUX_HEADERS_VERSION)),)
> +LINUX_HEADERS_SITE := $(LINUX_HEADERS_SITE)testing/
> +endif
> +

Thanks for your patch, and sorry for the slow response. However,
instead of having a special case for -rc kernels, I'd prefer to either
have a way of specifying a custom Linux kernel tarball for
linux-headers, or even better, a way of using the same kernel headers
source code as the ones used to build the Linux kernel package itself.

So, for now, I'll mark this specific patch as Rejected, but I'll
definitely welcome improvements in one of the two directions proposed
above.

Thanks again!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-04-20  9:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-25 13:22 [Buildroot] [PATCH] Added support for linux headers for testing versions to build cross-compile tools Lucas Zampar Bernardi
2014-04-20  9:07 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140420110724.5981255d@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox