Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support: properly check bash is available
Date: Sun, 20 Apr 2014 11:14:03 +0200	[thread overview]
Message-ID: <20140420111403.4d0fd54a@skate> (raw)
In-Reply-To: <1395185629-728-1-git-send-email-yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On Wed, 19 Mar 2014 00:33:49 +0100, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> The current check is broken, as it only checks if the user's login
> shell is bash, not what the system shell is.
> 
> Mimick the sequence found in the top-level Makefile to search for
> bash, except for the fallback case, where we explicitly check that
> 'sh' is bash, by checking if it sets $BASH, so we know the fallback
> case, in the top-level Makefile, to use 'sh' will indeed use bash.
> 
> Remove superfluous semi-colons ';' at the end of lines, they are
> not needed in a shell script (this is not C!)
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Peter Korsgaard <jacmet@uclibc.org>
> Cc: Andrew Barnes <andy@outsideglobe.com>
> ---
>  support/dependencies/dependencies.sh | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-04-20  9:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 23:33 [Buildroot] [PATCH] support: properly check bash is available Yann E. MORIN
2014-04-20  9:14 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140420111403.4d0fd54a@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox