From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libcap: add menu entry to install tools.
Date: Mon, 21 Apr 2014 11:40:04 +0200 [thread overview]
Message-ID: <20140421114004.33a1911f@skate> (raw)
In-Reply-To: <1398022213-9728-1-git-send-email-eric.le.bihan.dev@free.fr>
Dear Eric Le Bihan,
On Sun, 20 Apr 2014 21:30:13 +0200, Eric Le Bihan wrote:
> libcap provides a set of tools to manipulate capabilities, among which
> `setcap(8)` and `getcap(8)`. A new menu entry has been added to install them.
>
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> ---
> package/libcap/Config.in | 14 ++++++++++++++
> package/libcap/libcap.mk | 13 +++++++++++--
> 2 files changed, 25 insertions(+), 2 deletions(-)
I applied this patch, but I had to make heavy changes to it: you didn't
take into account the !MMU case, and the BR2_PREFER_STATIC_LIB case.
The first was easy to solve: programs cannot be built in a !MMU
configuration. The second one required more work, as your original
patch changes to run 'make' at the root of the libcap sources, which
doesn't work to build only the libcap.a library in a static library
context. So I had to revert your solution, and instead to a 'make' in
the libcap/ directory, and another 'make' in the progs/ directory.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-04-21 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 19:30 [Buildroot] [PATCH 1/1] libcap: add menu entry to install tools Eric Le Bihan
2014-04-21 9:40 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140421114004.33a1911f@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox