From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1 v2] qdecoder : new package
Date: Tue, 22 Apr 2014 16:27:11 +0200 [thread overview]
Message-ID: <20140422162711.7b4d0c17@skate> (raw)
In-Reply-To: <1398155122-6872-1-git-send-email-sagaert.johan@skynet.be>
Dear Sagaert Johan,
Thanks for this contribution! Some comments below.
On Tue, 22 Apr 2014 10:25:22 +0200, Sagaert Johan wrote:
> diff --git a/package/qdecoder/Config.in b/package/qdecoder/Config.in
> new file mode 100644
> index 0000000..2bd2a2f
> --- /dev/null
> +++ b/package/qdecoder/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_QDECODER
> + bool "qdecoder"
Really no toolchain dependency? From a quick look, qdecoder always
tries to build a shared library, so this is going to play nice with
BR2_PREFER_STATIC_LIB.
Can you try to build this library with the following toolchain
configurations:
http://autobuild.buildroot.org/toolchains/configs/free-electrons/bfin-linux-uclibc.config
http://autobuild.buildroot.org/toolchains/configs/free-electrons/bfin-uclinux.config
http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-basic.config
http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-full-nothread.config
It will exercise a bit the needed toolchain dependencies.
> +QDECODER_CONF_OPT = \
> + --prefix=$(STAGING_DIR)/usr \
> + --libdir=$(STAGING_DIR)/usr/lib
This looks strange, and normally not needed for autotools packages. Why
is it needed here? At least, if it's really needed, a comment above it
to explain why would be necessary (and I believe it's needed because
the package uses autoconf, but not automake: there is a Makefile.in
and not a Makefile.am).
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-22 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 8:25 [Buildroot] [PATCH 1/1 v2] qdecoder : new package Sagaert Johan
2014-04-22 12:35 ` Alexander Lukichev
2014-04-22 13:58 ` Mike Zick
2014-04-22 14:27 ` Thomas Petazzoni [this message]
2014-04-22 15:07 ` Sagaert Johan
2014-04-22 21:41 ` Thomas Petazzoni
2014-04-24 20:43 ` Sagaert Johan
2014-04-25 7:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422162711.7b4d0c17@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox