Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] zeromq: disable test_fork
Date: Tue, 22 Apr 2014 23:37:48 +0200	[thread overview]
Message-ID: <20140422233748.3b2b0599@skate> (raw)
In-Reply-To: <1398192173-5081-1-git-send-email-jerzy.grzegorek@trzebnica.net>

Dear Jerzy Grzegorek,

On Tue, 22 Apr 2014 20:42:52 +0200, Jerzy Grzegorek wrote:

> diff --git a/package/zeromq/zeromq-01-disable-test_fork.patch b/package/zeromq/zeromq-01-disable-test_fork.patch
> new file mode 100644
> index 0000000..48a76ab
> --- /dev/null
> +++ b/package/zeromq/zeromq-01-disable-test_fork.patch
> @@ -0,0 +1,22 @@
> +Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>

Even though this patch is quite trivial, we need a patch description
anyway.

> +
> +--- a/tests/Makefile.am	2014-04-18 15:24:35.000000000 +0200
> ++++ b/tests/Makefile.am	2014-04-22 11:31:08.000000000 +0200
> +@@ -46,8 +46,7 @@ if !ON_MINGW
> + noinst_PROGRAMS += test_shutdown_stress \
> +                    test_pair_ipc \
> +                    test_reqrep_ipc \
> +-                   test_timeo \
> +-                   test_fork
> ++                   test_timeo
> + endif
> + 
> + test_system_SOURCES = test_system.cpp
> +@@ -93,7 +92,6 @@ test_shutdown_stress_SOURCES = test_shut
> + test_pair_ipc_SOURCES = test_pair_ipc.cpp testutil.hpp
> + test_reqrep_ipc_SOURCES = test_reqrep_ipc.cpp testutil.hpp
> + test_timeo_SOURCES = test_timeo.cpp
> +-test_fork_SOURCES = test_fork.cpp
> + endif
> + 
> + #  Run the test cases

I would actually prefer a patch that adds an AC_CHECK_FUNCS([fork])
test to configure.ac, and uses that to build test_fork or not. In this
case, the patch could be submitted upstream.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-04-22 21:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 18:42 [Buildroot] [PATCH 1/1] zeromq: disable test_fork Jerzy Grzegorek
2014-04-22 21:37 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140422233748.3b2b0599@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox