From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] About static linking
Date: Wed, 23 Apr 2014 22:52:43 +0200 [thread overview]
Message-ID: <20140423225243.38a542c0@skate> (raw)
In-Reply-To: <a2d055301fd7b62deb7599263ad3ff0ee94c1870.1398283199.git.baruch@tkos.co.il>
Dear Baruch Siach,
On Wed, 23 Apr 2014 22:59:59 +0300, Baruch Siach wrote:
> +DHCPDUMP_LIBS = -lpcap
> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> +DHCPDUMP_LIBS += $(shell $(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs)
> +endif
This is not at all against your patch specifically, but I'm a bit
worried about all the static linking related kludges we add all over
the place. Is this normal? Shouldn't we fix the packages themselves and
submit patches upstream?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-23 20:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 19:59 [Buildroot] [PATCH] dhcpdump: fix static build Baruch Siach
2014-04-23 20:52 ` Thomas Petazzoni [this message]
2014-04-24 4:29 ` [Buildroot] About static linking Baruch Siach
2014-04-24 7:16 ` Thomas Petazzoni
2014-04-24 15:23 ` Peter Korsgaard
2014-04-24 22:01 ` Arnout Vandecappelle
2014-05-07 20:48 ` [Buildroot] [PATCH] dhcpdump: fix static build Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423225243.38a542c0@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox