From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] zeromq: don't use fork() on noMMU platforms
Date: Sat, 26 Apr 2014 11:47:01 +0200 [thread overview]
Message-ID: <20140426114701.23e40741@skate> (raw)
In-Reply-To: <1398492531-2946-1-git-send-email-jerzy.grzegorek@trzebnica.net>
Dear Jerzy Grzegorek,
On Sat, 26 Apr 2014 08:08:51 +0200, Jerzy Grzegorek wrote:
> +- int pid = fork ();
> ++#ifdef HAVE_FORK
> ++ int pid = fork();
> ++#else
> ++ int pid = vfork();
> ++#endif
Are you sure the child immediately does an exec() ? vfork() is not
equivalent to fork(), so one cannot be blindly replaced by the other.
Since the whole test is dedicated to testing fork, I think it doesn't
make sense to build it. So, your previous patch was better, it is just
that your previous patch was completely removing the build of
test_fork, while it should be conditional on whether the platform
implements fork() or not.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-04-26 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 6:08 [Buildroot] [PATCH v2 1/1] zeromq: don't use fork() on noMMU platforms Jerzy Grzegorek
2014-04-26 9:47 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140426114701.23e40741@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox