From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Mon, 28 Apr 2014 21:52:41 +0200 Subject: [Buildroot] [PATCH 9/9] boot/syslinux: add an option to install an MBR blob In-Reply-To: <535E8070.9090405@mind.be> References: <535E8070.9090405@mind.be> Message-ID: <20140428195241.GG3501@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout, All, On 2014-04-28 18:23 +0200, Arnout Vandecappelle spake thusly: ^^^^^ I don't know why, but I only received it now (delivered to my server at 21:03:30 +0200) ? ... :-/ > On 25/04/14 00:30, Yann E. MORIN wrote: > > From: "Yann E. MORIN" > > > > This MBR blob will look for an active partition, and boot the bootcode > > present in that partition. This can be used to boot an extlinux-prepared > > partition. > > > > Signed-off-by: "Yann E. MORIN" > > Cc: Thomas Lundquist > > Cc: Frank Hunleth > > --- > > boot/syslinux/Config.in | 13 ++++++++++++- > > boot/syslinux/syslinux.mk | 1 + > > 2 files changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/boot/syslinux/Config.in b/boot/syslinux/Config.in > > index d556c55..7d4dd08 100644 > > --- a/boot/syslinux/Config.in > > +++ b/boot/syslinux/Config.in > > @@ -15,7 +15,7 @@ choice > > > > config BR2_TARGET_SYSLINUX_LEGACY_BIOS > > bool "bios (legacy)" > > - select BR2_TARGET_SYSLINUX_ISOLINUX if !BR2_TARGET_SYSLINUX_PXELINUX > > + select BR2_TARGET_SYSLINUX_ISOLINUX if !BR2_TARGET_SYSLINUX_HAS_BIOS_IMG > > Hm, I don't really like this very much. Adding complexity like this for > behaviour which is not even really perfect... Since you replied to my other reply (he!), I think switching all of this to a all-choice makes this comment moot, right? :-) > > +config BR2_TARGET_SYSLINUX_MBR > > + bool "mbr" > > + select BR2_TARGET_SYSLINUX_HAS_BIOS_IMG > > + help > > + Install the legacy BIOS 'mbr' image, to boot off a > > See my comment in 4/9 about "legacy". Ditto, already covered. > BTW, while you're at it, perhaps you can add options for syslinux (=fat) > and extlinux? For extlinux, please see my previous answer. I'll have a look at syslinux, but I believe it is the same as extlinux. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'