From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Wed, 30 Apr 2014 20:05:28 +0200 Subject: [Buildroot] Patchwork cleanup #8: submitter notification In-Reply-To: <20140430194048.1e070625@skate> References: <20140429210905.GE3248@free.fr> <20140430005249.2d0f01de@skate> <20140430165659.GA3336@free.fr> <20140430194048.1e070625@skate> Message-ID: <20140430180528.GC3336@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Thomas, All, On 2014-04-30 19:40 +0200, Thomas Petazzoni spake thusly: > On Wed, 30 Apr 2014 18:56:59 +0200, Yann E. MORIN wrote: > > > > We do a "chown -R 0:0" on all files in the root filesystem, before > > > taking into account device tables. So I don't see how an ownership on > > > the build machine can leak into the generated root filesystem. > > > > chown does not change the ownership of a symlink, only that of the > > pointed-to entity: > > > > $ touch titi > > $ ln -s titi toto > > $ sudo chown root:root toto > > $ ls -l titi toto > > -rw-r--r-- 1 root root 0 Apr 30 18:55 titi > > lrwxrwxrwx 1 ymorin ymorin 4 Apr 30 18:55 toto -> titi > > > > So the symlink's ownership is not modified. > > Should we do a chown -h -R 0:0 then? Oh, Neat! I did not know about -h. I was afraid that was a recent addition, but it's been in chown since 1996-05-19, so we can safely assume that even enterprise distros (that get updated once in a blue moon) will all have it. Yeah! :-) I'll cook up a patch. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'