Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] uboot.pbl - make 'include' issue
Date: Thu, 1 May 2014 02:26:28 +0200	[thread overview]
Message-ID: <20140501022628.5da50090@skate> (raw)
In-Reply-To: <20140430230240.GH3336@free.fr>

Dear Yann E. MORIN,

On Thu, 1 May 2014 01:02:40 +0200, Yann E. MORIN wrote:

> > I haven't looked at the details, but linux/linux.mk seems to be doing
> > the exact same thing with the "Linux extensions" for real-time, and
> > doesn't appear to have any problem. It does:
> > 
> > include $(sort $(wildcard linux/linux-ext-*.mk))
> > 
> > $(eval $(generic-package))
> > 
> > So by the time generic-package is expanded, the last included makefile
> > is not linux.mk. And still the thing works.
> 
> Indeed, but the includes are all in the same directory, so pkgdir still
> return "linux" and thus the pkgname is correct.
> 
> In Ryan's case, the included Makefiles are in sub-dirs of uboot, so
> pkgdir returns that last sub-dir, hence the wrong pkgname.

Aah, good point. So I'll have to think more about this U-Boot extension
thing to find a more appropriate solution to suggest to Ryan.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-05-01  0:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 21:20 [Buildroot] uboot.pbl - make 'include' issue Ryan Barnett
2014-04-30 22:39 ` Yann E. MORIN
2014-04-30 22:42   ` Yann E. MORIN
2014-04-30 22:47   ` Thomas Petazzoni
2014-04-30 23:02     ` Yann E. MORIN
2014-05-01  0:26       ` Thomas Petazzoni [this message]
2014-05-01 16:58       ` rjbarnet at rockwellcollins.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140501022628.5da50090@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox