From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0 of 2 v2] Using gdb in buildroot
Date: Sat, 3 May 2014 22:25:46 +0200 [thread overview]
Message-ID: <20140503202546.GI10671@free.fr> (raw)
In-Reply-To: <3babace9-ca13-4ca8-93c0-7968fde20fb0@email.android.com>
Thomas,
On 2014-05-03 22:18 +0200, Thomas De Schampheleire spake thusly:
> hi Thomas,
>
> Thomas Petazzoni <thomas.petazzoni@free-electrons.com> schreef:
> >Dear Thomas De Schampheleire,
> >
> >On Sat, 03 May 2014 16:09:51 +0200, Thomas De Schampheleire wrote:
> >
> >> This a small respin of two patches that Thomas Petazzoni sent to the list a
> >> while back, adding a gdbinit file and updating the manual.
> >
> >Thanks for this update! However, it looks like you haven't preserved
> >the authorship on these patches, even though your modifications are
> >apparently relatively small. Is that intended?
>
> I'm not sure what you mean.I left your original sob line and added mine below. Isn't this leaving the authorship with you?
> I thought this is the right strategy when sending even slightly modified patches of someone else. If this is incorrect, please clarify and accept my apologies...
What Thomas meant, you forgot to commit with:
git commit --author='Thomas P. <...@...>'
when you adopted the patch, hence you are now credited as the author of
that patch, not the other Thomas.
That's a mistake that is easily done when using 'patch -p1 <file.patch'.
If you had been using 'pwclient am PATH-ID' instead, it would have kept
the authorship.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2014-05-03 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 14:09 [Buildroot] [PATCH 0 of 2 v2] Using gdb in buildroot Thomas De Schampheleire
2014-05-03 14:09 ` [Buildroot] [PATCH 1 of 2 v2] toolchain: generate a gdbinit file Thomas De Schampheleire
2014-05-03 14:09 ` [Buildroot] [PATCH 2 of 2 v2] docs/manual: document how to use the cross debugger Thomas De Schampheleire
2014-05-03 19:20 ` [Buildroot] [PATCH 0 of 2 v2] Using gdb in buildroot Thomas Petazzoni
2014-05-03 20:18 ` Thomas De Schampheleire
2014-05-03 20:25 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140503202546.GI10671@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox